feat: Adding flow statistics for arbitrary mesh cell element sets#4005
Open
MelReyCG wants to merge 386 commits into
Open
feat: Adding flow statistics for arbitrary mesh cell element sets#4005MelReyCG wants to merge 386 commits into
MelReyCG wants to merge 386 commits into
Conversation
…https://github.com/GEOS-DEV/GEOS into feature/amandinehry/create-yaml-file-and-structure-2
…file-and-structure-2' into refactor/dudes/error-context
…onents' into feature/rey/arbitrary-regions-stats
MelReyCG
added
the
flag: requires rebaseline
…ary-regions-stats
MelReyCG
requested review from
bd713,
corbett5,
cssherman,
jafranc and
wrtobin
as code owners
…tatistics-components
…onents' into feature/rey/arbitrary-regions-stats
…onents' into feature/rey/arbitrary-regions-stats
MelReyCG
added
ci: run CUDA builds
Base automatically changed from
bugfix/rey/split-statistics-components
to
develop
July 7, 2026 12:46
…ary-regions-stats
…ary-regions-stats
MelReyCG
removed
ci: run CUDA builds
Contributor
Author
|
DetailsError message: |
MelReyCG
added
ci: run CUDA builds
Contributor
Author
|
To test the fix, modified https://github.com/GEOS-DEV/GEOS/blob/develop/inputFiles/poromechanicsFractures/Contact/AugmentedLagrangianMultipliers/ALM_multiphasePoromechanics_curvedFrac_smoke.xml. Thanks @jhuang2601 for reporting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at extending the flow statistics components by introducing an optional
setNamesparameter toSinglePhaseStatisticsandCompositionalMultiphaseStatistics, allowing users to obtain statistics computation from arbitrary mesh element sets instead of being forced to process solver regions.Sets can already be defined with
Geometryobjects likeBox.Multiple set can be provided for a given statistics component, and in that case, statistics over all provided sets are also logged. To support intersecting sets and give valid statistics, they are computed on a compound set (union of all selected set).
Here is an example:
The infrastructure proposed here can be re-used for new statistics components which would process cell elements, and is implemented at the
StatisticsAggregatorBaselevel, introduced in the PR #3836 .The parameter has been used in the
simpleCo2InjTutorialexample to test that functionnality.