fix(reactor): Retain externally referenced resource resolver types - #46
Merged
meck-gd merged 1 commit intoOct 5, 2026
Conversation
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes invalid output when a .NET Reactor resource resolver type is still used by application code.
When resource decryption and method inlining were enabled, de4dot always removed the detected resource-resolver type. The sample I came across retained externally callable resolver helpers, and other module types still reference those methods after deobfuscation. Removing the resolver type leaves a dangling method reference and causes dnlib to reject the output while writing method bodies.
Now before removing the resolver type, scan methods outside that type for calls to resolver methods other than its initializer and retain the type when an external reference remains.