Repository navigation
chore: sync with upstream/main (83a3674ff) - #86
Conversation
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… run (pingdotgg#30326) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…om under the pointer (pingdotgg#30346) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…1631) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ng (pingdotgg#31665) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…rive letter (pingdotgg#22534) Co-authored-by: Alb11747 <40252880+Alb11747@users.noreply.github.com>
…3445) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ead (pingdotgg#26492) Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
…rver reports (pingdotgg#28781) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
…tgg#28800) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ading (pingdotgg#29661) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gdotgg#29933) Co-authored-by: maria-rcks <maria@kuuro.net>
…utton (pingdotgg#30372) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ngdotgg#30817) Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
…ingdotgg#27034) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
… and mobile (pingdotgg#27798) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tgg#30425) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…equest card (pingdotgg#31653) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
pingdotgg#31769) Co-authored-by: Aditya Vardhan Sharma <adityaradhika13@gmail.com>
Co-authored-by: Lakshmi Tanmay <lakshmi@voltcrash.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
pingdotgg#32035) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…#32325) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…2269) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…32263) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…the system language (pingdotgg#32252)
…2231) Co-authored-by: maria-rcks <maria@kuuro.net>
…24202) Co-authored-by: PR Batch Tester <agent@local.test> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net>
… user's branch Upstream's setup cleanup force-deletes the branch a failed or cancelled worktree launch created. With Check out in worktree, that branch is the user's own, so the cleanup now deletes only a branch the launch created.
…pstream replaced Upstream now always shows a project's Checkouts section so a lone checkout's grouping rule can be changed, so the fork's rule for when to show it has no reader left. projectCheckoutTargets returns the machines that can gain a checkout.
…ronment Upstream moved desktop backend configuration onto HostProcess.Environment and now rejects process.env reads in Effect code. The fork's WSL primary read T3CODE_PUBLIC_URL from process.env, so desktop failed to typecheck.
The MCP tool list is upstream's 48,119 bytes plus the fork's existing 1,005 bytes for schedule targets and createBranch.
Upstream renamed the test crypto layer to SecureRandom, stopped providing it through NodeServices, and reads the project's working tree root in the branch selector. The fork's dictation test keeps the vertical split on mod+shift+s (ADR 0017).
…tory Upstream split the single executable into a small bootstrap and an embedded CLI asset, so dist-exe/bin.mjs no longer holds the release repository define and every scheduled fork release would fail. The check now reads the binary, which holds the define only when it was baked in.
Upstream passes --offline to every short-lived Pi process. omp rejects unknown flags at startup, so its models, presets, text generation and thread forks all failed. Short-lived launches now set PI_OFFLINE=1, which Pi documents as the same switch and omp ignores.
The Checkouts paragraph still described the fork's old visibility rule and the command-palette route, both gone.
Records upstream's lower-cased PR reply matching as an accepted gap in ADR 0002.
Upstream lets child-process arguments and environment values be redacted, so the OhMyPi preset tests convert them to strings as upstream's own tests do.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Thanks for the work on speech input and the persistence/runtime improvements. There is one retry-compatibility issue to resolve before merging. OverviewSummaryThis change adds environment and cloud speech transcription, batches provider snapshot commits, replaces event compaction with retention-based pruning, and updates runtime dependencies and packaging. The main concern is preserving command retry behavior when the event log no longer contains the original command results. Main Issues⚫️ [PROBLEM] Pruning removes results still required by accepted-command retries — Recommendation: request changes for the retry regression above. Additional NotesValidation was limited to source and test inspection; no tests or builds were executed. The inline comment could not be published because the review API rejected its diff path, so the verified finding is recorded here. |
Problem
The fork is 628 commits behind
upstream/main. This sync keeps the features recorded indocs/adrand uses upstream's implementation wherever it can.Change
Merged
pingdotgg/t3codemain at83a3674ffd84. 27 files conflicted, and 3 upstream workflow changes hit workflows the fork deletes (desktop-macos-preview.yml,release-desktop.yml,release.yml), which stay deleted per ADR 0011.git show --remerge-diff 70a42ae18cshows the whole conflict resolution.Re-homed on upstream's structure
resolveUpdateTarget: builds without the define pick the version from the mirror or the channel as upstream does, and fork builds keep following their own latest release.ci.ymlkeeps the fork's job layout, ports upstream's surrogate-pair output filter intoTest, and keeps the built-web boot check inTest Web, since the fork has no build job.env.createBranchclause is added to upstream's rewrittent3_thread_launchdescription. Themod+ssplits sit beside upstream's newmod+shift+ddictation shortcut.Fixes for new upstream interactions
fix(server): upstream now force-deletes the branch of a worktree launch that fails or is cancelled during setup (#28373, #29781). With Check out in worktree (ADR 0008), that was the user's existing branch. The cleanup now deletes only a branch the launch created. The extended test fails on the merge commit.fix(ci): upstream split the executable into a bootstrap and an embedded CLI asset (#29284), sodist-exe/bin.mjsno longer holds the release-repository define and every scheduled fork release would fail. The check now greps the binary. I built it locally both ways: the repository is found with the define and absent without it.fix(pi): upstream passes--offlineto short-lived Pi processes (#30187). OhMyPi rejects unknown flags (Error: unknown flag: --offline), so discovery, presets (ADR 0025), text generation and thread forks all failed. These launches now setPI_OFFLINE=1, which Pi documents as the same switch and omp ignores. Verified against the installed omp.fix(desktop): the WSL primary readsT3CODE_PUBLIC_URLfromHostProcess.Environment. Upstream's newprocessEnvInEffectrule failed desktop's typecheck.refactor(client-runtime): upstream now always shows project settings' Checkouts section (#23641). The fork's visibility rule had no reader left, soprojectCheckoutOptionsbecameprojectCheckoutTargets. The user doc's stale Checkouts paragraph is rewritten.test: fork tests follow upstream's harness changes (SecureRandom,NodeCrypto.layer,workingTreein VCS status, redacted child-process values).chore(server):mcpToolListJsonBytesis 49,124, upstream's 48,119 plus the fork's unchanged 1,005.Implemented upstream: nothing this round replaces a fork feature. Upstream's always-visible Checkouts section supersedes ADR 0022's visibility rule; the fork's Add checkout entry stays.
ADRs
All ADRs now compare against
83a3674ff. Notes were added or rewritten in 0002 (accepted gap: upstream's lower-cased PR reply matching), 0008, 0011 (failure-mode check, mirror interplay, version core0.1.7), 0021, 0022 and 0025.Declined, already true upstream:
schedule_taskwithscheduledTaskIdignores upstream's newfreshSession. Upstream's update branch has the same omission, so this PR leaves it alone.Scope and approval
This is a maintainer-requested sync of the fork onto upstream. Every fork divergence is covered by an ADR in
docs/adr.Verification
vp run check:changed: format, lint, knip, GraphQL, typecheck (40 packages), tests 3167/3167 (147 files), and React compiler coverage all pass.fix(ci),fix(pi)andfix(desktop)commits above.GitManagertests needGIT_CONFIG_GLOBAL=/dev/null, and Chromium needed NixOS libraries onLD_LIBRARY_PATH.vp check, a manual pass in a real client, the fork release workflow end to end, and themcp-tool-useeval for the mergedt3_thread_launchdescription (paid models).Model: Claude Opus 5.5; harness: Claude Code in T3 Code.
🤖 Generated with Claude Code