Skip to content

Update StatisticsMaintenanceCronjob.php #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skerbis merged 1 commit into from
Aug 4, 2026
Merged

Update StatisticsMaintenanceCronjob.php #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions lib/StatisticsMaintenanceCronjob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

class rex_statistics_maintenance_cronjob extends rex_cronjob
{
private int $deferredDeleteBatches = 0;

public function execute(): bool
{
$daysToKeepRaw = max(1, (int) $this->getParam('days_to_keep_raw', 120));
Expand Down Expand Up @@ -59,6 +61,9 @@ public function execute(): bool
$message .= ', verbleibend bis Vollzyklus: ' . $optimizedRemaining . ' von ' . $optimizedTotal;
}
}
if ($this->deferredDeleteBatches > 0) {
$message .= ', ' . $this->deferredDeleteBatches . ' Lösch-Batches wegen DB-Locks vertagt';
}
$this->setMessage($message);

return true;
Expand Down Expand Up @@ -338,7 +343,7 @@ private function deleteOrphanUrlStatusChunked(int $chunkSize = 5000): int
*/
private function runDeleteWithRetry(string $query, array $params = []): int
{
$maxRetries = 3;
$maxRetries = 5;

for ($attempt = 1; $attempt <= $maxRetries; ++$attempt) {
try {
Expand All @@ -347,17 +352,36 @@ private function runDeleteWithRetry(string $query, array $params = []): int

return (int) $sql->getRows();
} catch (rex_sql_exception $exception) {
$message = $exception->getMessage();
$isLockTimeout = false !== strpos($message, '1205') || false !== strpos(strtolower($message), 'lock wait timeout');

if (!$isLockTimeout || $attempt >= $maxRetries) {
if (!$this->isRetryableLockException($exception)) {
throw $exception;
}

usleep(250000);
if ($attempt >= $maxRetries) {
// Wartung darf bei kurzfristigen DB-Locks nicht vollständig fehlschlagen.
++$this->deferredDeleteBatches;

return 0;
}

usleep(100000 * $attempt);
}
}

return 0;
}

private function isRetryableLockException(rex_sql_exception $exception): bool
{
$errorCode = $exception->getErrorCode();
if (1205 === $errorCode || 1213 === $errorCode) {
return true;
}

$message = strtolower($exception->getMessage());

return false !== strpos($message, '1205')
|| false !== strpos($message, '1213')
|| false !== strpos($message, 'lock wait timeout')
|| false !== strpos($message, 'deadlock found');
}
}