Repository navigation
Goal: Make the driver-side rescue reachable for CLOSED-but-unmerged PRs. The goa - #348
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated task via
devagent task.Prompt
Goal: Make the driver-side rescue reachable for CLOSED-but-unmerged PRs. The goal-text derivation (internal/loopdriver/run.go:413-431) assigns
pick.mergePRonly whenprViewreads state==OPEN, andopenPROfIssue(issues.go:208) returns only OPEN PRs, soverifyAndMergeRescue's OPEN guard (run.go:807) can never receive a closed number — extend both ends. ExtendprViewto decode baseRefName/headRefName; when a goal-named PR is CLOSED, unmerged, based on main, and its head ref still exists on origin, take it as the merge subject; then letverifyAndMergeRescuereopen it (gh pr reopen, repo-scoped, bounded, drain-tolerant), re-read state, and merge viamergePRBounded. Base-superseded or reopen-refused → 0, never a fabricated ship. Cover both with run_test.go's fake-gh harness;go test ./internal/loopdriver/passes.Repo policy: every PR keeps docs/PRD.md current — update the sections this change affects (status claims, architecture notes, roadmap/completion notes) and bump the Last updated footer in the same PR. A PR that changes repo state without reflecting it in docs/PRD.md is incomplete.
PRD state update (repo policy)