Skip to content

Inline commits swallow rules in clang-tidy config #904

Closed

Description

@olantwin

If I'm not mistaken, the incline configs in multi-line sections is split on commas, so that here:

phlex/.clang-tidy

Lines 21 to 25 in 7b5ac2e

-llvm-header-guard, # Use scripts/fix_header_guards.py instead
misc-*,
-misc-non-private-member-variables-in-classes,
-misc-no-recursion,
modernize-*,

# Use scripts/fix_header_guards.py instead misc-*, is parsed, so that the misc-* rules are never enabled and the following two lines become no-ops.

Activity

  1. added theissue type on Sep 22, 2026
  2. knoepfel commented on Sep 22, 2026

    @knoepfel
    Member

    🤦‍♂️ Thank you @olantwin for detecting this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions