Repository navigation
ci: pin actionlint version and add pre-commit hook #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
greenc-FNAL
wants to merge
1
commit into
main
Choose a base branch
from
ci/pin-actionlint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| if [[ "$(uname -s)" == Darwin ]]; then | ||
| printf '%s\n' "actionlint: ShellCheck skipped on Darwin due to actionlint's pipe deadlock; CI runs it on Linux." >&2 | ||
| exec actionlint -shellcheck= "$@" | ||
| fi | ||
|
|
||
| exec actionlint "$@" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: Framework-R-D/action-prepare-check-outputs
Length of output: 4225
Script executed:
Repository: Framework-R-D/action-prepare-check-outputs
Length of output: 2285
Web query:
actionlint v1.7.12 go.mod go 1.25.0Result:
Web query:
pre-commit Go hook language_version install environment GOTOOLCHAIN localResult:
Script executed:
Repository: Framework-R-D/action-prepare-check-outputs
Length of output: 2982
Set the actionlint hook's Go version.
When matching workflow files are present, pre-commit uses the system Go by default. With Go 1.24.5 and
GOTOOLCHAIN=local, installing actionlint v1.7.12 fails because it requires Go 1.25.0.Set the hook's
language_version:Suggested fix
Pre-commit's Go backend downloads and uses the requested Go version, so this setting supplies Go 1.25.0 even when the developer's system toolchain is Go 1.24.5. A run with no matching workflow files is skipped before the hook environment is installed, so that case is not blocked.
Committable suggestion