Repository navigation
ci: pin actionlint version and add pre-commit hook - #53
greenc-FNAL wants to merge 1 commit into
Conversation
- Pin the CI actionlint version to 1.7.12 for consistent checks. - Add a pre-commit hook using a wrapper that skips ShellCheck on Darwin to avoid actionlint’s pipe deadlock.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Pre-commit invocation and CI version .pre-commit-config.yaml, scripts/pre-commit/actionlint.sh, .github/workflows/ci.yaml |
The pre-commit hook runs the script with verbose output. On Darwin, the script disables ShellCheck; on other platforms, it runs actionlint normally. Both paths forward arguments. CI specifies actionlint version 1.7.12. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Merge Risk: 
Minimal · up to 556af
-
The pinned actionlint versions and platform-specific wrapper are consistent with the stated CI and pre-commit behavior.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title "ci: pin actionlint version and add pre-commit hook" matches the main changes. The workflow now pins actionlint to 1.7.12, a pre-commit hook for actionlint is added at v1.7.12, and a wrapper script skips ShellCheck on Darwin. The title states both primary changes in one concise, specific sentence, and it uses the conventional commit prefix. It omits the Darwin ShellCheck workaround, which is a detail and not the main point.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the actionlint version alignment and macOS-specific ShellCheck workaround.
No open issues 🎉
What changed in this PR
Aligns local and CI workflow validation on actionlint 1.7.12, with a macOS-specific workaround for the reported ShellCheck pipe deadlock.
Changes:
- Pins actionlint to version 1.7.12 in CI and pre-commit.
- Adds a pre-commit wrapper that disables ShellCheck on Darwin while leaving it enabled on Linux.
| File | Description |
|---|---|
scripts/pre-commit/actionlint.sh |
Wraps actionlint with Darwin-specific ShellCheck handling and a notice. |
.pre-commit-config.yaml |
Adds the pinned actionlint hook using the wrapper. |
.github/workflows/ci.yaml |
Pins the CI actionlint version to 1.7.12. |
Review effort: Balanced
Summary
Dependencies
This PR contains one commit directly above
upstream/mainand changes only the CI workflow, pre-commit configuration, and actionlint wrapper. It is independent of the guardrail PR and can merge in either order.Validation
git diff --checkpassed.actionlintversion to1.7.12.rhysd/actionlinthook at revisionv1.7.12, using the new wrapper script.