Skip to content

ci: pin actionlint version and add pre-commit hook - #53

Open
greenc-FNAL wants to merge 1 commit into
mainfrom
ci/pin-actionlint
Open

greenc-FNAL wants to merge 1 commit into
mainfrom
ci/pin-actionlint

Conversation

@greenc-FNAL

@greenc-FNAL greenc-FNAL commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Pin CI and pre-commit to actionlint 1.7.12 for consistent workflow validation.
  • Add the pinned actionlint pre-commit hook and a wrapper that skips ShellCheck on Darwin to avoid actionlint's pipe deadlock; Linux CI retains ShellCheck.
  • Preserve the existing actionlint commit without including the separate guardrail changes.

Dependencies

This PR contains one commit directly above upstream/main and changes only the CI workflow, pre-commit configuration, and actionlint wrapper. It is independent of the guardrail PR and can merge in either order.

Validation

  • Pre-commit checks passed for all three changed files before pushing.
  • The complete commit diff and branch tracking were inspected.
  • git diff --check passed.
  • CI: Pins the actionlint version to 1.7.12.
  • Pre-commit: Adds the rhysd/actionlint hook at revision v1.7.12, using the new wrapper script.
  • Platform handling: On Darwin, the wrapper disables ShellCheck integration and prints a notice because of an actionlint pipe deadlock. On other platforms, it runs actionlint normally. Linux CI continues to run actionlint through the workflow.
  • Tests: Results were not provided.

- Pin the CI actionlint version to 1.7.12 for consistent checks.
- Add a pre-commit hook using a wrapper that skips ShellCheck on Darwin to avoid actionlint’s pipe deadlock.
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 28168b1b-6a18-4c41-9b23-2942d2aea7a9
Commits

Reviewing files that changed from the base of the PR and between 6dcadc3 and 556afdd.

Files selected for processing: 3
  • .github/workflows/ci.yaml
  • .pre-commit-config.yaml
  • scripts/pre-commit/actionlint.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Context from checks skipped due to timeout: 1
  • GitHub Check: setup
Additional context used
Code guidelines: 1
AGENTS.md — auto-discovered
Path-based instructions: 1
Source excerpt: YAML: formatted with prettier (120-char soft limit, 2-space indent).

CodeRabbit inference engine (AGENTS.md)

Files:

  • .pre-commit-config.yaml
  • .github/workflows/ci.yaml
Additional comments: 3
.pre-commit-config.yaml: 1

50-55: LGTM!

scripts/pre-commit/actionlint.sh: 1

1-9: LGTM!

.github/workflows/ci.yaml: 1

64-64: LGTM!

Walkthrough

The pre-commit configuration adds an actionlint hook that runs a platform-aware script. On Darwin, the script disables ShellCheck. The CI workflow specifies actionlint version 1.7.12.

Changes: Actionlint setup

Layer / File(s) Summary
Pre-commit invocation and CI version
.pre-commit-config.yaml, scripts/pre-commit/actionlint.sh, .github/workflows/ci.yaml
The pre-commit hook runs the script with verbose output. On Darwin, the script disables ShellCheck; on other platforms, it runs actionlint normally. Both paths forward arguments. CI specifies actionlint version 1.7.12.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to 556af

The pinned actionlint versions and platform-specific wrapper are consistent with the stated CI and pre-commit behavior.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "ci: pin actionlint version and add pre-commit hook" matches the main changes. The workflow now pins actionlint to 1.7.12, a pre-commit hook for actionlint is added at v1.7.12, and a wrapper…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci: pin actionlint version and add pre-commit hook" matches the main changes. The workflow now pins actionlint to 1.7.12, a pre-commit hook for actionlint is added at v1.7.12, and a wrapper script skips ShellCheck on Darwin. The title states both primary changes in one concise, specific sentence, and it uses the conventional commit prefix. It omits the Darwin ShellCheck workaround, which is a detail and not the main point.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the actionlint version alignment and macOS-specific ShellCheck workaround.

No open issues 🎉

What changed in this PR

Aligns local and CI workflow validation on actionlint 1.7.12, with a macOS-specific workaround for the reported ShellCheck pipe deadlock.

Changes:

  • Pins actionlint to version 1.7.12 in CI and pre-commit.
  • Adds a pre-commit wrapper that disables ShellCheck on Darwin while leaving it enabled on Linux.
File Description
scripts/​pre-commit/​actionlint.sh Wraps actionlint with Darwin-specific ShellCheck handling and a notice.
.pre-commit-config.yaml Adds the pinned actionlint hook using the wrapper.
.github/​workflows/​ci.yaml Pins the CI actionlint version to 1.7.12.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants