Repository navigation
ci: pin actionlint version and add pre-commit hook - #52
greenc-FNAL wants to merge 1 commit into
Conversation
- Pin the CI actionlint version to 1.7.12 for consistent linting. - Add an actionlint pre-commit hook with a Darwin workaround for ShellCheck's pipe deadlock.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Configure and run Actionlint .pre-commit-config.yaml, scripts/pre-commit/actionlint.sh, .github/workflows/ci.yaml |
The pre-commit hook uses Actionlint 1.7.12 and invokes the wrapper. The wrapper disables ShellCheck on Darwin and forwards arguments unchanged on other systems. The CI workflow also pins Actionlint to 1.7.12. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Other
Merge Risk: 
Minimal · up to 053f9
-
The change aligns CI and pre-commit on actionlint 1.7.12 while retaining ShellCheck outside Darwin. No concrete merge-blocking risk is identified.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the actionlint pinning and platform-aware pre-commit changes.
No open issues 🎉
What changed in this PR
This PR aligns local and CI workflow validation by pinning actionlint to version 1.7.12 and adding a platform-aware pre-commit wrapper.
Changes:
- Pin CI and the new pre-commit hook to actionlint 1.7.12.
- Skip ShellCheck on Darwin to avoid the reported pipe deadlock, while retaining it in Linux CI.
- Enable verbose output for the pre-commit hook.
| File | Description |
|---|---|
scripts/pre-commit/actionlint.sh |
Wraps actionlint with a Darwin-specific ShellCheck bypass. |
.pre-commit-config.yaml |
Adds the pinned actionlint hook using the wrapper. |
.github/workflows/ci.yaml |
Pins the CI actionlint version to 1.7.12. |
Review effort: Balanced
Summary
Dependencies
This PR contains one commit directly above
upstream/mainand changes only the CI workflow, pre-commit configuration, and actionlint wrapper. It is independent of the guardrail PR and can merge in either order.Validation
git diff --checkpassed.1.7.12.rhysd/actionlinthook at revisionv1.7.12, with verbose output.git diff --checkpassed. These results are author-reported; no independent test run was provided.