Skip to content

ci: pin actionlint version and add pre-commit hook - #52

Open
greenc-FNAL wants to merge 1 commit into
mainfrom
ci/pin-actionlint
Open

greenc-FNAL wants to merge 1 commit into
mainfrom
ci/pin-actionlint

Conversation

@greenc-FNAL

@greenc-FNAL greenc-FNAL commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Pin CI and pre-commit to actionlint 1.7.12 for consistent workflow validation.
  • Add the pinned actionlint pre-commit hook and a wrapper that skips ShellCheck on Darwin to avoid actionlint's pipe deadlock; Linux CI retains ShellCheck.
  • Preserve the existing actionlint commit without including the separate guardrail changes.

Dependencies

This PR contains one commit directly above upstream/main and changes only the CI workflow, pre-commit configuration, and actionlint wrapper. It is independent of the guardrail PR and can merge in either order.

Validation

  • Pre-commit checks passed for all three changed files before pushing.
  • The complete commit diff and branch tracking were inspected.
  • git diff --check passed.
  • CI: Pin the actionlint workflow check to version 1.7.12.
  • Pre-commit: Add the rhysd/actionlint hook at revision v1.7.12, with verbose output.
  • Code quality: Add a wrapper that skips ShellCheck on Darwin to avoid an actionlint pipe deadlock. On other platforms, it runs actionlint normally. Linux CI retains ShellCheck.
  • Tests: The PR description reports that pre-commit checks passed for the three changed files and that git diff --check passed. These results are author-reported; no independent test run was provided.

- Pin the CI actionlint version to 1.7.12 for consistent linting.
- Add an actionlint pre-commit hook with a Darwin workaround for ShellCheck's pipe deadlock.
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b7341fb0-a84a-445f-8097-6ef2bd71171f
Commits

Reviewing files that changed from the base of the PR and between bad4323 and 053f9ba.

Files selected for processing: 3
  • .github/workflows/ci.yaml
  • .pre-commit-config.yaml
  • scripts/pre-commit/actionlint.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Context from checks skipped due to timeout: 1
  • GitHub Check: setup
Additional context used
Code guidelines: 1
AGENTS.md — auto-discovered
Path-based instructions: 1
Source excerpt: YAML: formatted with prettier (120-char soft limit, 2-space indent).

CodeRabbit inference engine (AGENTS.md)

Files:

  • .pre-commit-config.yaml
  • .github/workflows/ci.yaml
Walkthrough

The CI workflow pins Actionlint to 1.7.12. Pre-commit runs the matching Actionlint hook through a Bash wrapper. On Darwin, the wrapper disables ShellCheck; on other systems, it forwards the supplied arguments unchanged.

Changes: Actionlint integration

Layer / File(s) Summary
Configure and run Actionlint
.pre-commit-config.yaml, scripts/pre-commit/actionlint.sh, .github/workflows/ci.yaml
The pre-commit hook uses Actionlint 1.7.12 and invokes the wrapper. The wrapper disables ShellCheck on Darwin and forwards arguments unchanged on other systems. The CI workflow also pins Actionlint to 1.7.12.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: Minimal · up to 053f9

The change aligns CI and pre-commit on actionlint 1.7.12 while retaining ShellCheck outside Darwin. No concrete merge-blocking risk is identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the two main changes: pinning the actionlint version and adding a pre-commit hook.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the actionlint pinning and platform-aware pre-commit changes.

No open issues 🎉

What changed in this PR

This PR aligns local and CI workflow validation by pinning actionlint to version 1.7.12 and adding a platform-aware pre-commit wrapper.

Changes:

  • Pin CI and the new pre-commit hook to actionlint 1.7.12.
  • Skip ShellCheck on Darwin to avoid the reported pipe deadlock, while retaining it in Linux CI.
  • Enable verbose output for the pre-commit hook.
File Description
scripts/​pre-commit/​actionlint.sh Wraps actionlint with a Darwin-specific ShellCheck bypass.
.pre-commit-config.yaml Adds the pinned actionlint hook using the wrapper.
.github/​workflows/​ci.yaml Pins the CI actionlint version to 1.7.12.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants