Repository navigation
Conversation
- Keep LockException from RenewAsync out of the resilience policy so a lost lock fails immediately - Return Failed between migrations when the renewal after a completed migration loses the lock - Return Cancelled for cancelled non-versioned migrations instead of marking them complete - Add regression tests and move test assemblies to xunit v3 Parallelization attribute
This was referenced Oct 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MigrationManagerrenews its migration lock withRenewAsync. Foundatio#580 makes that throwLockExceptionwhen the lock is lost (it used to silently succeed), so migrations need to handle it instead of retrying or carrying on.Changes
Failedso the next migration doesn't start.Cancelled.Parallelizationattribute, which 4.0.1 requires.Tests
Two new migration tests cover lock loss during and between migrations. Repositories.Tests (152) pass. Elasticsearch tests mostly passed (684 of 689), and the 5 failures passed when rerun individually.
Draft until #580 is released.