Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily and monthly index names now use Gregorian dates regardless of the process culture, matching the existing parser. Both nested date-formatting calls explicitly use
CultureInfo.InvariantCulture. Previously, Thai and Arabic calendars could produce names that maintenance interpreted as future or ancient Gregorian partitions.Validation: 30 synthetic culture tests pass (12 failed before the fix), 152 local core tests pass, and the full Release solution builds with zero warnings/errors using published package dependencies. Independent Astra review found no blockers. Exact-head CI passed all 869 tests, including the Elasticsearch suite, on its first attempt. Local checks used no live services; hosted integration tests used CI containers.
Rollout warning: Existing culture-generated physical indexes and aliases are not automatically migrated and remain susceptible to incorrect date interpretation. Review affected deployments before rollout; this PR does not rename, delete, or migrate existing indexes or aliases.
Verification and implementation details
en-US,de-DE,fr-FR,th-TH, andar-SA.events-v2-2569.10.05; Arabic producedevents-v2-1448.04.24. Synthetic Gregorian maintenance skipped expired Thai partitions and selected a recent Arabic partition. Deletion was overridden to record names only, and test configuration rejects Elasticsearch client access.Parallelization(Mode = None)because current main's xUnit package rejects the old properties at compile time. Test parallelization remains disabled; dependencies and workflows are unchanged.dotnet build Foundatio.Repositories.slnx --configuration Release -p:ReferenceFoundatioSource=false -p:ReferenceFoundatioRepositoriesSource=false.dotnet tests/Foundatio.Repositories.Elasticsearch.Tests/bin/Release/net10.0/Foundatio.Repositories.Elasticsearch.Tests.dll -class Foundatio.Repositories.Elasticsearch.Tests.TimeSeriesIndexCultureTests.dotnet tests/Foundatio.Repositories.Tests/bin/Release/net10.0/Foundatio.Repositories.Tests.dll.5ee616b79bf8dcd6e65e10113c3f8f93ddcad16d: 869 passed, 0 failed, 0 skipped; build had zero warnings/errors. Packaging and both publishing steps were skipped.