Repository navigation
Redis queue: round-trip GroupId - #190
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1636ad051c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Updated 2026-10-06: reviewed repairs are now pushed at The build caller is pinned to guarded core commit Repair and local validation evidenceThe shared empty-GroupId method had no discovered provider wrapper. The repair adds its Fact registration. All 3 GroupId cases passed against disposable local Redis 8.6 with sibling core source. Temporary source-reference path adjustments were restored; dependency versions are unchanged. No production Redis or provider concurrency experiment was used. These local checks ran on 2026-10-05. Application/test source is unchanged from those validated repair commits; this follow-through added only the approved workflow guard/pin. YAML parsing and diff checks passed. No new local application test run is claimed. |
…ness The GroupId APIs are not in 13.0.4. Use the nightly until a release is available.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Downstream CI pin: this PR consumes |
The Redis worker loop logged dequeue errors and immediately looped again without counting them. It now counts them, ignores cancellation only when its own token is cancelled, and waits one second before retrying. Documents why the delayed-retry GroupId test is skipped: Redis requeues delayed retries in the minute-interval maintenance task.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Fixed the intermittent test-setup failure |
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What this adds
Support for the new
QueueEntryOptions.GroupIdfrom Foundatio core.Redis queues are plain lists, so
GroupIddoesn't change ordering or fairness. It is stored as metadata in the payload envelope and returned onIQueueEntry.GroupIdwhen the message is dequeued. It is also kept when the message is retried.Changes
RedisPayloadEnvelope<T>.GroupId(new optional property). Older payloads without it deserialize withGroupId = null.Enqueuedevent and the dequeued entry both carryGroupId.Tests
QueueTestBasetests: round-trip, kept on retry, empty means no group.Independent dependency validation: core and TestHarness now use matching published
13.0.5-preview.0.10from core #57907568d0e. The original published-package solution build failed three CS0115 overrides; this two-pin correction builds the full Release solution with zero warnings/errors and source linking disabled. All 38 existing offline pattern/date utility tests pass locally. Local Redis backend tests were not run; both normal hosted runs pass at0cc084ff: Redis CI, 910 passed, 0 failed, 26 skips. CI and stable package publication steps are skipped. The existing delayed GroupId retry skip is unchanged.Compatibility
Old messages already in the queue still deserialize with the new optional field absent. This PR consumes the matching core/TestHarness preview adding
GroupId; stable release ordering and broader Properties-wrapper compatibility remain coordinated with core (FoundatioFx/Foundatio#579).Update
GetQueueaccept the newgroupIdResolverparameter (breakingQueueTestBasesignature change in Add GroupId to queues (tenant/group key with SQS fair-queue, FIFO, and Service Bus session support) Foundatio#579), and run the shared resolver tests.13.0.5-preview.0.10.