Skip to content

Access check (temporary) - #1387

Closed
Broadscotty wants to merge 44 commits into
FossifyOrg:mainfrom
Broadscotty:cleo/access-check
Closed

Broadscotty wants to merge 44 commits into
FossifyOrg:mainfrom
Broadscotty:cleo/access-check

Conversation

@Broadscotty

Copy link
Copy Markdown

Temporary PR opened by Cleo to verify pull-request rights. Closed and branch deleted immediately after.

Broadscotty and others added 14 commits September 17, 2026 13:17
…le view) (#3)

* Debug logging + fallback for simple list snap

- Log now, fetch window, first 12 events with raw TS and endTS>now,
  chosen target index, and first-visible position after layout (tag CalSL)
- Fallback: when no event has endTS > now, scroll to today's section
  instead of leaving the list at the top of yesterday
- Re-assert scroll after first layout in case state restoration or the
  layout animation overrides the initial post() scroll

* Fix detekt magic number findings in debug logging

* Show snap diagnostics in an on-screen overlay (no adb needed)

* Snap to first not-ended event that STARTED TODAY

Multi-day events from earlier days (e.g. a parking booking starting
Sep 21 ending tonight 23:00) sort above today's sections, so the old
endTS>now pick scrolled the list into yesterday (Scott's reported
symptom). Prefer today-started timed events, then today-started, then
the old behavior, then today's section header.

* Today button snaps to current time; remove debug overlay

- goToToday() in the simple all-events list (mDayCode empty) now
  reuses scrollToNextAppointment() so it lands on what's running now
  or the next appointment instead of the top of today's section
- Strips all temporary diagnostics: CalSL log lines, constants, and
  the on-screen debug TextView (root cause confirmed via overlay)

* Setting: custom colour for today's circle in month view

The today circle used the app's primary colour, making it invisible
against same-coloured content. New 'Color of today's circle in month
view' row in Settings next to the weekend highlight colour opens the
standard colour picker. Unset (0) keeps the old primary-colour look.
Selected-today stroke uses the configured colour too. Included in
settings export/import.

---------

Co-authored-by: Cleo <cleo@dyksterhuis.com>

@Broadscotty Broadscotty left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review path verified.

@fossifybot

fossifybot Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Fossify accepts code contributions only for open issues labeled help wanted. This pull request does not meet that requirement or one of the documented exceptions, so it is being closed without review. Please read the contribution guidelines before starting work.

@fossifybot fossifybot Bot closed this Oct 27, 2026
@Broadscotty
Broadscotty deleted the cleo/access-check branch October 27, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant