Repository navigation
Add component tests for notification-bell with unread badge and statetransitions - #885
Merged
Austinaminu2 merged 1 commit intoSep 28, 2026
Merged
Conversation
… transitions Created notification-bell.test.tsx covering: unread count badge display (0, 2, 99+ cap), markAllRead callback firing on panel open, Escape-key-to-close behavior, empty "No notifications yet" state, notification click interactions with markAsRead, and rendering multiple notifications. Tests mock the useNotifications hook with complete control over notifications, unread count, and all callback functions. Add component tests for activity-feed pagination and filtering Created activity-feed.test.tsx covering: empty state "No activity yet" rendering, hasMore/loadMore pagination button visibility and click handling, load-more button disabled state during loading, event-type filter button rendering, filtering events by type, calling filterByType on filter click, highlighting selected filter, displaying all events, and reverse chronological ordering. Tests verify each interactive behavior independently with controlled mock data. Add Storybook stories for accessible-countdown-timer component Created accessible-countdown-timer.stories.tsx with stories for far-future targets (30 days), imminent targets (<1 minute), expired targets, 1-day remaining, 1-hour remaining, 5-minute remaining, custom ended labels, and multiple timers. Stories include screen-reader announcement text showing what assistive devices will announce for each state, demonstrating live-region updates and accessibility labels for visually hidden output. Add Storybook stories for accessible-unlock-amount component Created accessible-unlock-amount.stories.tsx with stories for 0% unlocked (no unlock yet), 25% unlocked, 50% partially unlocked, 75% unlocked, 100% fully unlocked, large amount examples, and unlock state comparison. Stories demonstrate all numeric states from zero to complete unlock with different token symbols (USDC, EUR, USDT), and include screen-reader announcements showing how accessible component communicates unlock progress to assistive devices. Closes FlowwStar#646 Closes FlowwStar#647 Closes FlowwStar#717 Closes FlowwStar#718
|
@edwardfavour998-code Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created notification-bell.test.tsx covering: unread count badge display (0, 2, 99+ cap), markAllRead callback firing on panel open, Escape-key-to-close behavior, empty "No notifications yet" state, notification click interactions with markAsRead, and rendering multiple notifications. Tests mock the useNotifications hook with complete control over notifications, unread count, and all callback functions.
Add component tests for activity-feed pagination and filtering
Created activity-feed.test.tsx covering: empty state "No activity yet" rendering, hasMore/loadMore pagination button visibility and click handling, load-more button disabled state during loading, event-type filter button rendering, filtering events by type, calling filterByType on filter click, highlighting selected filter, displaying all events, and reverse chronological ordering. Tests verify each interactive behavior independently with controlled mock data.
Add Storybook stories for accessible-countdown-timer component
Created accessible-countdown-timer.stories.tsx with stories for far-future targets (30 days), imminent targets (<1 minute), expired targets, 1-day remaining, 1-hour remaining, 5-minute remaining, custom ended labels, and multiple timers. Stories include screen-reader announcement text showing what assistive devices will announce for each state, demonstrating live-region updates and accessibility labels for visually hidden output.
Add Storybook stories for accessible-unlock-amount component
Created accessible-unlock-amount.stories.tsx with stories for 0% unlocked (no unlock yet), 25% unlocked, 50% partially unlocked, 75% unlocked, 100% fully unlocked, large amount examples, and unlock state comparison. Stories demonstrate all numeric states from zero to complete unlock with different token symbols (USDC, EUR, USDT), and include screen-reader announcements showing how accessible component communicates unlock progress to assistive devices.
Closes #646
Closes #647
Closes #717
Closes #718
name: Pull request
about: Describe a focused change and how it was verified
title: 'feat: '
labels: enhancement
Issue
Closes #
Summary
Describe the user or maintainer-facing change.
Changes
Test plan
Checklist