Skip to content

Spec/row actions update - #14

Merged
paodb merged 5 commits into
spec/row-actionsfrom
spec/row-actions-20260616
Jun 18, 2026
Merged

paodb merged 5 commits into
spec/row-actionsfrom
spec/row-actions-20260616

Conversation

@javier-godoy

@javier-godoy javier-godoy commented Jun 16, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Control default button styling for row actions
    • Customize row actions rendering strategy
    • Refresh row actions after styling updates
  • API Changes

    • Row actions now use .remove() method instead of grid's removal method
  • Documentation

    • Updated API documentation and usage examples for row actions

@javier-godoy javier-godoy changed the title Spec/row actions 20260616 Spec/row actions update Jun 16, 2026
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c4ba1406-771d-45f8-9378-ff095723404c

📥 Commits

Reviewing files that changed from the base of the PR and between df345c9 and 28c38d5.

📒 Files selected for processing (1)
  • FEATURE_ROW_ACTIONS.md

Walkthrough

FEATURE_ROW_ACTIONS.md is updated to remove the removeRowAction method from the EasyGrid API section, add three new methods (setDefaultRowActionVariants, setRowActionsRenderer, refreshRowActions), expand EasyRowAction with a styling/variants section, and revise usage examples accordingly.

Changes

EasyGrid Row Actions Documentation

Layer / File(s) Summary
EasyGrid API surface changes
FEATURE_ROW_ACTIONS.md
Removes the documented removeRowAction(EasyRowAction<T>) entry from the EasyGrid API section; adds documentation for setDefaultRowActionVariants(ButtonVariant...), setRowActionsRenderer(RowActionsRenderer<T>), and refreshRowActions().
EasyRowAction styling/variants section and remove() update
FEATURE_ROW_ACTIONS.md
Adds a "Styling and theme variants" section documenting that post-render style or variant changes require easyGrid.refreshRowActions(); removes the explicit equivalence of remove() to easyGrid.removeRowAction(this).
Usage examples update
FEATURE_ROW_ACTIONS.md
Replaces easyGrid.removeRowAction(adminAction) with adminAction.remove(), adds a setDefaultRowActionVariants(...) snippet, and updates the chained styling example to use addClassName(...).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • FlowingCode/EasyGridAddon#11: Previously updated FEATURE_ROW_ACTIONS.md to align the EasyGrid/EasyRowAction row-actions API around removeRowAction(EasyRowAction) and EasyRowAction.remove() semantics, which this PR directly supersedes.

Suggested reviewers

  • scardanzan
  • paodb
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Spec/row actions update' is vague and generic. While it mentions 'row actions', it uses non-descriptive language ('update') that doesn't clearly convey the specific nature of the changes such as the API refactoring, method removals, or additions. Consider a more specific title that captures the main change, such as 'Refactor row actions API: consolidate removal and add styling/rendering options' or 'Update EasyGrid row actions: remove removeRowAction method and add configuration methods'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spec/row-actions-20260616

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@javier-godoy

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@javier-godoy
javier-godoy requested review from paodb and scardanzan June 16, 2026 16:29
@javier-godoy
javier-godoy marked this pull request as ready for review June 16, 2026 16:29
@paodb
paodb merged commit aab5be4 into spec/row-actions Jun 18, 2026
1 of 2 checks passed
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Jun 18, 2026
@paodb
paodb deleted the spec/row-actions-20260616 branch June 18, 2026 13:57
javier-godoy added a commit that referenced this pull request Jun 19, 2026
…w-actions javadocs

- LitRendererBuilder: drop the now-unused bindAttributes (lifting removed); fix staticOnly javadoc.
- EasyRowAction: rename LIFTED_ICON_NAMES -> PRECEDENCE_ICON_NAMES and add size; correct class javadoc.
- RowActionsManager: correct class javadoc to mention all three RowActionsStyle modes.
- ROW-ACTIONS-TODO: add #14 (dropdown trigger-only open test).
@scardanzan scardanzan moved this from Pending release to Done in Flowing Code Addons Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants