Repository navigation
Conversation
n-lark
force-pushed
the
2322-data-store-charts
branch
from
October 21, 2026 21:49
b456397 to
61059c4
Compare
n-lark
marked this pull request as ready for review
October 21, 2026 22:04
6 of 15 tasks
n-lark
added this pull request to stack #2331
October 22, 2026 20:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Covers problems 1 and 3 of #2322; problem 2 (flow writes) follows in a separate PR.
Every chart point was a proxy, so filters read points through proxies and every 60th trim re-cloned the series. Now points are stored plain and wrapped only when read, as Vue 3 does, and trims are exact on every message without cloning. Other values are unchanged.
mainContract changes
_datapointis the same object as the chart's point, not the same proxy. Writes are still reported; match points by value, not===.filter/keepLatestPerTopiccallbacks get plain points, so changing them isn't reported (as onmain). No third-party widget callsfilter.Test plan
mainmain: same page-load data and reload for point-limit, time-window and categorical charts, text and gaugeRelated Issue(s)
Part of #2322
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel