Skip to content

Accessibility pass: keyboard focus trap in sheets #14

Open
#18
Open
Accessibility pass: keyboard focus trap in sheets#14
#18
Labels
area: frontendReact appcomplexity: trivialSmall, well-defined changegood first issueGood for newcomers

Description

@SYMBAxx
SYMBAxx
opened on Nov 5, 2026

Sheet closes on Escape but doesn't trap focus or restore it on close.

Acceptance: focus moves into the dialog on open, tab cycles inside, focus returns to the trigger on close.

Activity

  1. SYMBAxx
    added
    good first issueGood for newcomers
    complexity: trivialSmall, well-defined change
    area: frontendReact app
    on Nov 5, 2026

  2. NePreby commented on Nov 6, 2026

    @NePreby
    NePreby
    on Nov 6, 2026

    I have implemented the keyboard focus trap and restoration for Sheet dialogs in PR #18 (#18).

    • Focus automatically moves inside dialog upon open.
    • Tab / Shift+Tab cycles focus trapped within dialog elements.
    • Focus restores to the triggering element upon close.
    • Comprehensive unit tests added and passing in CI (src/lib/__tests__/focus.test.ts).

    Payout Address (Binance TRC20):
    TMqmJjRgVS21NL2eFtfyHciTxvE4BqGmEv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: frontendReact appcomplexity: trivialSmall, well-defined changegood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions