feat(__future__): Actionable error message for duplicate priorities in update-flag - #8303
feat(__future__): Actionable error message for duplicate priorities in update-flag#8303emyller wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
📝 WalkthroughWalkthroughPriority validation now groups ordered segment overrides by priority and detects conflicts. Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The change makes duplicate-priority errors identify the conflicting segments; validation may incur extra query materialization for unusually large feature configurations, but no actionable merge-blocking risk remains. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a9f3ce4 to
c60cf82
Compare
Docker builds report
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 91e51c55-da0f-4422-b3b2-c51bb9f408f2
📒 Files selected for processing (3)
api/features/future/exceptions.pyapi/features/future/services.pyapi/tests/integration/features/future/test_flag_endpoint.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8303 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 1604 1604
Lines 64335 64344 +9
=======================================
+ Hits 63551 63560 +9
Misses 784 784 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
✅ private-cloud · depot-ubuntu-latest-16 — run #19410 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19410 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
✅ private-cloud · depot-ubuntu-latest-16 — run #19411 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
✅ oss · depot-ubuntu-latest-arm-16 — run #19411 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19411 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Skipped testsfirefox › tests/onboarding-tests.pw.ts › Onboarding › New user connects via the single-page onboarding flow @oss ✅ oss · depot-ubuntu-latest-arm-16 — run #19410 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
|
✅ oss · depot-ubuntu-latest-16 — run #19411 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
|
✅ oss · depot-ubuntu-latest-16 — run #19410 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
Thanks for submitting a PR! Please check the boxes below:
I have added information todocs/if required so people know about the feature.Changes
Closes #8301
Evolve conflicting segment override priority error message from, e.g.:
To, e.g.:
How did you test this code?
Integration tests.