fix: Identity overrides silently lost during local evaluation - #240
Merged
Conversation
Flags._resolve_flag built its trimmed evaluation context by re-keying segments on the SegmentContext `key` field. Identity-override segments are all mapped with an empty `key`, so every one of them collided on "" and only the last survived: identities other than the last one to override a given feature fell back to the environment default. Key the segment overrides index by the evaluation context's own segment keys instead, so the trimmed context stays a faithful subset of the environment and no re-keying happens at all. Identity-override segments now also carry their unique key rather than an empty one. beep boop
matthewelwell
requested review from
matthewelwell
and removed request for
emyller
August 14, 2026 14:11
matthewelwell
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #239.
How did you test this code?
Added a second identity override to
tests/data/environment.json, and a unit test.