fix(pgbouncer): PgBouncer is unreachable when the release name does not contain "flagsmith" - #574
Merged
Conversation
matthewelwell
approved these changes
Jul 31, 2026
matthewelwell
left a comment
Contributor
There was a problem hiding this comment.
How will this affect existing deployments?
Member
Author
The host only changes where it did not match the Service, so PgBouncer was already unreachable |
germangarces
force-pushed
the
fix/pgbouncer-hostname-release-name-mismatch
branch
from
July 31, 2026 13:03
c6f2ae6 to
079b7ad
Compare
germangarces
enabled auto-merge (squash)
July 31, 2026 13:09
…ot contain "flagsmith"
germangarces
force-pushed
the
fix/pgbouncer-hostname-release-name-mismatch
branch
from
July 31, 2026 13:11
079b7ad to
722bf00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
Changes
With PgBouncer switched on, the API never started — it could not reach PgBouncer.
The chart built PgBouncer's name in two different ways, so the address given to the API did not match the name of the PgBouncer service. They only matched when the release name contained "flagsmith", which is what our docs use, so nobody hit it.
flagsmithflagsmith-pgbouncerflagsmith-pgbouncerfsfs-flagsmith-pgbouncerfs-pgbouncerNote for release notes: anyone who worked around this with
fullnameOverridewill see the address change again.How did you test this code?
helm install fs charts/flagsmith -n test --set pgbouncer.enabled=true --waitBefore: API pod stuck retrying
could not translate host name "fs-pgbouncer...".After: install finishes, API pod
1/1 Running, PgBouncer logs show it logging in.Also rendered four release names plus
nameOverrideandfullnameOverride— address matches the service every time, and the names that already worked are unchanged.helm lintpasses. Kubernetes v1.35.1.Review effort: 1/5