fix(templates): pick up manual edits when regenerating artifacts#1368
Open
clay-good wants to merge 1 commit into
Open
fix(templates): pick up manual edits when regenerating artifacts#1368clay-good wants to merge 1 commit into
clay-good wants to merge 1 commit into
Conversation
…g the next one The continue/propose/ff workflow instructions said to "read dependency files for context," but an agent that already saw those files earlier in the session treats them as read and regenerates downstream artifacts from its stale in-context copy. Editing spec.md and deleting design.md/tasks.md to regenerate them silently produced artifacts based on the pre-edit spec. The step guidance, the guardrails, and the `openspec instructions` dependency block now say explicitly: re-read dependency files from disk even if seen earlier in the conversation, because the user may have edited them. Discussion: #909 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughWorkflow instructions and continue, fast-forward, and propose templates now require rereading dependency artifacts from disk before generating subsequent artifacts. Template parity hashes and patch release metadata were updated accordingly. ChangesDependency reread guidance
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: Ready for review. Tests green (the 17 zsh-installer failures locally are the known oh-my-zsh environment issue; unaffected in CI).
What was wrong: Edit
spec.md, deletedesign.md/tasks.md, run/opsx:continue— and the regenerated files ignore your edits. The workflow instructions say to "read dependency files for context," but an agent that already saw those files earlier in the session treats them as read and regenerates from its stale in-context copy. Reported in discussion #909, and it's why the delete-and-continue workaround people land on in #600, #1291, and #705 feels unreliable.How it was fixed: The continue, propose, and fast-forward instructions (skill + command variants) and the
<dependencies>block emitted byopenspec instructionsnow say explicitly: re-read dependency files from disk before creating the next artifact, even if you saw them earlier in the conversation — the user may have edited them.Proof: Guidance-only change — no behavior code touched.
npm run buildregenerated the templates and the golden hashes inskill-templates-parity.test.tswere updated fromdist/; the parity suite and the full test suite pass (1,858 tests).Notes: This doesn't add staleness detection or a regeneration command (that's issue #705 / the
add-artifact-regeneration-supportproposal). It just makes the existing "delete the downstream file and continue" path reliably see current file contents.Discussion: #909
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation
Chores