Skip to content

docs(readme): show what a spec actually looks like in "See it in action"#1365

Open
clay-good wants to merge 1 commit into
mainfrom
docs/readme-spec-example
Open

docs(readme): show what a spec actually looks like in "See it in action"#1365
clay-good wants to merge 1 commit into
mainfrom
docs/readme-spec-example

Conversation

@clay-good

@clay-good clay-good commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Status: Ready for review. Docs-only — 23 lines added to README.md, nothing else touched.

What was missing: The "See it in action" walkthrough shows /opsx:propose creating a specs/ folder, but the README never shows what a spec actually contains. That is the first thing a newcomer evaluating OpenSpec wants to see — and exactly what discussion #1024 (originally filed as #1022) asks for: "actual spec powering this example are not seen anywhere … maybe link specs of openspec if you use it on this repo?"

What it does: Adds a collapsible "What do the specs actually look like?" block right after the walkthrough transcript, containing:

  • a short example spec delta for the walkthrough's dark-mode feature (## ADDED Requirements### Requirement:#### Scenario: with WHEN/THEN), matching the real delta format used across this repo's own changes
  • links to this repo's live openspec/specs and openspec/changes, since OpenSpec is built with OpenSpec — real examples at scale

Proof: The example format was checked against real artifacts in this repo (openspec/changes/simplify-skill-installation/specs/propose-workflow/spec.md, openspec/specs/context-injection/spec.md). Collapsed by default, so the README's above-the-fold flow is unchanged.

Notes: Answers discussion #1024. Written with Claude Code using Claude Fable 5 (claude-fable-5).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Added a collapsible README section explaining the contents of the specs/ folder.
    • Included a Markdown example showing a theme selection requirement and dark mode scenario.

Answers discussion #1024: the README walkthrough showed the workflow
creating specs/ but never the content of a spec. Add a collapsible
example spec delta right after the transcript, plus links to this
repo's own live openspec/specs and openspec/changes as real examples.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@clay-good clay-good requested a review from TabishB as a code owner July 15, 2026 15:07
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

README.md now includes a collapsible section explaining generated specs/ content, with an example showing a theme selection requirement and a dark mode scenario.

Changes

README documentation

Layer / File(s) Summary
Generated spec example
README.md
Adds a collapsible section describing generated specs and showing formatted requirement and scenario text for theme selection and dark mode.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: tabishb

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the README documentation change and matches the new spec example added after the "See it in action" section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/readme-spec-example

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Around line 82-85: Update the README guidance around the `specs/` folder and
the `## ADDED Requirements` example to explicitly identify it as a change delta
format for `openspec/changes/<name>/specs/`, and distinguish it from permanent
specs, which use `## Requirements`. Clarify that the delta format should not be
copied into archived or permanent specs.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b0cb2fb2-9653-4774-9dc0-7aefb42e3f22

📥 Commits

Reviewing files that changed from the base of the PR and between 0a99f41 and 55c5978.

📒 Files selected for processing (1)
  • README.md

Comment thread README.md
Comment on lines +82 to +85
Plain Markdown — requirements with concrete scenarios, no special syntax to learn. Here's what goes in the `specs/` folder created above:

```markdown
## ADDED Requirements

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Clarify that this is a change delta, not a permanent spec.

The sample starts with ## ADDED Requirements, which is the format parsed from a change’s openspec/changes/<name>/specs/ directory. Permanent specs use ## Requirements; calling this simply the specs/ folder could lead readers to copy the delta format into archived specs and fail validation.

Proposed wording
-Plain Markdown — requirements with concrete scenarios, no special syntax to learn. Here's what goes in the `specs/` folder created above:
+Plain Markdown — requirements with concrete scenarios, no special syntax to learn. Here's what goes in the change's `specs/` folder created above:
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Plain Markdown — requirements with concrete scenarios, no special syntax to learn. Here's what goes in the `specs/` folder created above:
```markdown
## ADDED Requirements
Plain Markdown — requirements with concrete scenarios, no special syntax to learn. Here's what goes in the change's `specs/` folder created above:
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` around lines 82 - 85, Update the README guidance around the
`specs/` folder and the `## ADDED Requirements` example to explicitly identify
it as a change delta format for `openspec/changes/<name>/specs/`, and
distinguish it from permanent specs, which use `## Requirements`. Clarify that
the delta format should not be copied into archived or permanent specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant