Repository navigation
Prm no clobber - #6
Merged
Merged
Conversation
Willmac16
force-pushed
the
prm-no-clobber
branch
from
November 9, 2026 14:38
456836f to
0d2d457
Compare
Willmac16
force-pushed
the
prm-no-clobber
branch
from
November 9, 2026 15:37
af8fa06 to
c9df173
Compare
pepepr08
approved these changes
Nov 9, 2026
pepepr08
left a comment
pepepr08
left a comment
There was a problem hiding this comment.
AI flagged that there is a behavior change that is worth investigating: Old: a VALID DB entry that failed to deserialize fell back to the clean default value with flag DEFAULT. New: flag becomes INVALID and m_X keeps whatever the failed deserializeTo partially wrote.
I actually prefer the new behavior so I'm approving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this means u can load from an overrides .dat file and not clobber all ur values w/ defaults