fix: switching from online video to offline video (or vice-versa) doesn't work

Author: Bnyro

app/src/main/java/com/github/libretube/helpers/NavigationHelper.kt

@@ -74,6 +74,8 @@ object NavigationHelper {
         val activity = ContextHelper.unwrapActivity<AbstractPlayerHostActivity>(context)
         val attachedToRunningPlayer = activity.runOnPlayerFragment {
             try {
+                if (this.isOffline != isOffline) return@runOnPlayerFragment false
+
                 PlayingQueue.clearAfterCurrent()
                 this.playNextVideo(videoId.toID())
 
@@ -95,6 +97,8 @@ object NavigationHelper {
 
         val audioOnlyMode = PreferenceHelper.getBoolean(PreferenceKeys.AUDIO_ONLY_MODE, false)
         val attachedToRunningAudioPlayer = activity.runOnAudioPlayerFragment {
+            if (this.isOffline != isOffline) return@runOnAudioPlayerFragment false
+
             PlayingQueue.clearAfterCurrent()
             this.playNextVideo(videoId.toID())
 

app/src/main/java/com/github/libretube/ui/fragments/AudioPlayerFragment.kt

@@ -82,7 +82,8 @@ class AudioPlayerFragment : Fragment(R.layout.fragment_audio_player), AudioPlaye
     private var handler = Handler(Looper.getMainLooper())
     private var isPaused = !PlayerHelper.playAutomatically
 
-    private var isOffline: Boolean = false
+    var isOffline: Boolean = false
+        private set
     private var playerController: MediaController? = null
 
     override fun onCreate(savedInstanceState: Bundle?) {

app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt

@@ -137,11 +137,12 @@ class PlayerFragment : Fragment(R.layout.fragment_player), CustomPlayerCallback
     private lateinit var videoId: String
     private var playlistId: String? = null
     private var channelId: String? = null
-    private var isOffline: Boolean = false
+    var isOffline: Boolean = false
+        private set
 
     // data and objects stored for the player
     private lateinit var streams: Streams
-    val isShort: Boolean
+    private val isShort: Boolean
         get() {
             if (PlayingQueue.getCurrent()?.isShort == true) return true
             if (!::playerController.isInitialized) return false
@@ -1106,6 +1107,9 @@ class PlayerFragment : Fragment(R.layout.fragment_player), CustomPlayerCallback
 
     /**
      * Manually skip to another video.
+     *
+     * You many only call this if the video is of the same type as the type of the currently running
+     * video, i.e. either both are online or both are offline.
      */
     fun playNextVideo(nextId: String) {
         playerController.sendCustomCommand(