fix: offline audio player transition, offline PiP/fullscreen

Author: Bnyro

app/src/main/AndroidManifest.xml

@@ -45,6 +45,7 @@
             android:name=".ui.activities.NoInternetActivity"
             android:label="@string/noInternet"
             android:launchMode="singleTop"
+            android:configChanges="keyboard|keyboardHidden|screenSize|smallestScreenSize|screenLayout|orientation|uiMode"
             android:supportsPictureInPicture="true"
             android:screenOrientation="locked" />
 

app/src/main/java/com/github/libretube/helpers/BackgroundHelper.kt

@@ -15,7 +15,7 @@ import com.github.libretube.parcelable.PlayerData
 import com.github.libretube.services.AbstractPlayerService
 import com.github.libretube.services.OfflinePlayerService
 import com.github.libretube.services.OnlinePlayerService
-import com.github.libretube.ui.activities.MainActivity
+import com.github.libretube.ui.activities.AbstractPlayerHostActivity
 import com.github.libretube.ui.activities.NoInternetActivity
 import com.github.libretube.ui.fragments.DownloadSortingOrder
 import com.github.libretube.ui.fragments.DownloadTab
@@ -42,7 +42,7 @@ object BackgroundHelper {
     ) {
         // close the previous video player if open
         val fragmentManager =
-            ContextHelper.unwrapActivity<MainActivity>(context).supportFragmentManager
+            ContextHelper.unwrapActivity<AbstractPlayerHostActivity>(context).supportFragmentManager
         fragmentManager.fragments.firstOrNull { it is PlayerFragment }?.let {
             fragmentManager.commit { remove(it) }
         }

app/src/main/java/com/github/libretube/helpers/NavigationHelper.kt

@@ -114,26 +114,26 @@ object NavigationHelper {
             // in contrast to the video player, the audio player doesn't start a media service on
             // its own!
             if (isOffline) {
-                BackgroundHelper.playOnBackground(
+                BackgroundHelper.playOnBackgroundOffline(
                     context,
                     videoId.toID(),
-                    timestamp,
                     playlistId,
-                    channelId,
-                    keepQueue
+                    downloadTab!!,
+                    shuffle,
+                    downloadSortingOrder
                 )
             } else {
-                BackgroundHelper.playOnBackgroundOffline(
+                BackgroundHelper.playOnBackground(
                     context,
                     videoId.toID(),
+                    timestamp,
                     playlistId,
-                    downloadTab!!,
-                    shuffle,
-                    downloadSortingOrder
+                    channelId,
+                    keepQueue
                 )
             }
 
-            openAudioPlayerFragment(context, minimizeByDefault = true)
+            openAudioPlayerFragment(context, offlinePlayer = isOffline, minimizeByDefault = true)
         } else {
             openVideoPlayerFragment(
                 context,

app/src/main/java/com/github/libretube/ui/fragments/AudioPlayerFragment.kt

@@ -14,6 +14,7 @@ import androidx.constraintlayout.motion.widget.MotionLayout
 import androidx.constraintlayout.motion.widget.TransitionAdapter
 import androidx.core.math.MathUtils.clamp
 import androidx.core.os.bundleOf
+import androidx.core.os.postDelayed
 import androidx.core.view.isGone
 import androidx.core.view.isVisible
 import androidx.fragment.app.Fragment
@@ -22,6 +23,7 @@ import androidx.fragment.app.commit
 import androidx.lifecycle.lifecycleScope
 import androidx.media3.common.MediaMetadata
 import androidx.media3.common.Player
+import androidx.media3.common.util.Log
 import androidx.media3.common.util.UnstableApi
 import androidx.media3.session.MediaController
 import com.github.libretube.R
@@ -112,7 +114,7 @@ class AudioPlayerFragment : Fragment(R.layout.fragment_audio_player), AudioPlaye
 
         // manually apply additional padding for edge-to-edge compatibility
         activity.getSystemInsets()?.let { systemBars ->
-            with (binding.audioPlayerMain) {
+            with(binding.audioPlayerMain) {
                 setPadding(
                     paddingLeft,
                     paddingTop + systemBars.top,
@@ -279,6 +281,7 @@ class AudioPlayerFragment : Fragment(R.layout.fragment_audio_player), AudioPlaye
         NavigationHelper.openVideoPlayerFragment(
             context = requireContext(),
             videoId = videoId,
+            isOffline = isOffline,
             alreadyStarted = true,
         )
     }