refactor: simplify and perf-improve PlayOfflineDialog logic

Author: Bnyro

app/src/main/java/com/github/libretube/services/AbstractPlayerService.kt

@@ -15,7 +15,6 @@ import androidx.media3.common.ForwardingPlayer
 import androidx.media3.common.MediaMetadata
 import androidx.media3.common.PlaybackException
 import androidx.media3.common.Player
-import androidx.media3.common.util.Log
 import androidx.media3.common.util.UnstableApi
 import androidx.media3.exoplayer.ExoPlayer
 import androidx.media3.exoplayer.trackselection.DefaultTrackSelector
@@ -244,12 +243,12 @@ abstract class AbstractPlayerService : MediaLibraryService(), MediaLibrarySessio
             setExtras(bundleOf(IntentData.segments to segments))
         }
 
-        Log.e("segments", sponsorBlockSegments.toString())
         checkForSegments()
     }
 
     /**
-     * check for SponsorBlock segments
+     * Check for SponsorBlock segments. This method automatically schedules itself to repeat every
+     * 100ms using [handler], so it's not needed to schedule it manually.
      */
     private fun checkForSegments() {
         handler.postDelayed(this::checkForSegments, 100)

app/src/main/java/com/github/libretube/ui/dialogs/PlayOfflineDialog.kt

@@ -9,7 +9,6 @@ import androidx.fragment.app.setFragmentResult
 import com.github.libretube.R
 import com.github.libretube.constants.IntentData
 import com.github.libretube.databinding.DialogPlayOfflineBinding
-import com.github.libretube.helpers.NavigationHelper
 import com.github.libretube.util.TextUtils
 import com.google.android.material.dialog.MaterialAlertDialogBuilder
 
@@ -30,12 +29,6 @@ class PlayOfflineDialog : DialogFragment() {
             .setTitle(R.string.dialog_play_offline_title)
             .setView(binding.root)
             .setPositiveButton(R.string.yes) { _, _ ->
-                NavigationHelper.navigateVideo(
-                    requireContext(),
-                    videoId = videoId,
-                    isOffline = true
-                )
-
                 setFragmentResult(
                     PLAY_OFFLINE_DIALOG_REQUEST_KEY,
                     bundleOf(IntentData.isPlayingOffline to true)

app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt

@@ -487,12 +487,11 @@ class PlayerFragment : Fragment(R.layout.fragment_player), CustomPlayerCallback
             fragmentManager.setFragmentResultListener(
                 PlayOfflineDialog.PLAY_OFFLINE_DIALOG_REQUEST_KEY, viewLifecycleOwner
             ) { _, bundle ->
-                if (bundle.getBoolean(IntentData.isPlayingOffline)) {
-                    // offline video playback started and thus the player fragment is no longer needed
-                    killPlayerFragment()
-                } else {
-                    attachToPlayerService(playerData, true)
-                }
+                isOffline = bundle.getBoolean(IntentData.isPlayingOffline)
+
+                // start a new playback session - the method will read `isOffline` and decide whether
+                // to play the downloaded video based on it, so it's enough to set `isOffline` here
+                attachToPlayerService(playerData, true)
             }
 
             val downloadInfo = DownloadHelper.extractDownloadInfoText(
@@ -548,12 +547,12 @@ class PlayerFragment : Fragment(R.layout.fragment_player), CustomPlayerCallback
     }
 
     private fun attachToPlayerService(playerData: PlayerData, startNewSession: Boolean) {
-        val (serviceClass, args) = if (playerData.isOffline) {
+        val (serviceClass, args) = if (isOffline) {
             val isNoInternet = activity is NoInternetActivity
 
             OfflinePlayerService::class.java to bundleOf(
                 IntentData.videoId to videoId,
-                IntentData.downloadTab to playerData.downloadTab,
+                IntentData.downloadTab to (playerData.downloadTab ?: DownloadTab.VIDEO),
                 IntentData.playlistId to playlistId,
                 IntentData.sortOptions to playerData.downloadSortingOrder,
                 IntentData.shuffle to playerData.shuffle,

app/src/main/java/com/github/libretube/ui/views/CustomExoPlayerView.kt

@@ -10,7 +10,6 @@ import android.os.Handler
 import android.os.Looper
 import android.text.format.DateUtils
 import android.util.AttributeSet
-import android.util.Log
 import android.view.KeyEvent
 import android.view.MotionEvent
 import android.view.Window
@@ -27,7 +26,6 @@ import androidx.core.view.isInvisible
 import androidx.core.view.isVisible
 import androidx.core.view.marginStart
 import androidx.core.view.updateLayoutParams
-import androidx.fragment.app.findFragment
 import androidx.lifecycle.LifecycleOwner
 import androidx.lifecycle.findViewTreeLifecycleOwner
 import androidx.media3.common.C
@@ -69,7 +67,6 @@ import com.github.libretube.ui.controllers.FullscreenGestureAnimationController
 import com.github.libretube.ui.dialogs.SubmitDeArrowDialog
 import com.github.libretube.ui.dialogs.SubmitSegmentDialog
 import com.github.libretube.ui.extensions.toggleSystemBars
-import com.github.libretube.ui.fragments.PlayerFragment
 import com.github.libretube.ui.interfaces.CustomPlayerCallback
 import com.github.libretube.ui.interfaces.PlayerGestureOptions
 import com.github.libretube.ui.interfaces.PlayerOptions
@@ -382,7 +379,6 @@ class CustomExoPlayerView(
         updateMarginsByFullscreenMode()
 
         commonPlayerViewModel?.isFullscreen?.observe(viewLifecycleOwner) { isFullscreen ->
-            Log.e("is full", isFullscreen.toString())
             updateTopBarMargin()
 
             binding.fullscreen.isInvisible = PlayerHelper.autoFullscreenEnabled