Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the power-profiles-daemon
HoldProfileAPI while GameMode is active.The first registered client requests the configured performance profile, and the final client releases it. The system D-Bus connection remains open for the lifetime of the hold, so daemon exit also releases it.
Behavior
org.freedesktop.UPower.PowerProfiles.net.hadess.PowerProfilesAPI used by older PPD versions and compatible implementations such as tuned-ppd.platform_profilehandling when neither API exists,desiredprofcannot be represented by a PPD hold, ordefaultprofrequests exact restoration semantics.No new dependency or configuration option is added; the implementation uses the existing sd-bus dependency.
Testing
scripts/format-check.sh-Dwith-examples=truemeson test -C builddir --print-errorlogsclang-tidyon the changed daemon sources (only existing project-wide logging warnings)Full
gamemoded -thardware validation is pending the local removal of competing ASUS profile writers, hence this is submitted as a draft.Fixes #333
Fixes #462