Repository navigation
grasp: coordination tests distinguish Git admission from collection ownership - #19
Merged
Merged
Conversation
…e limits of metadata collection coordination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The storage inventory identifies superseded metadata, but an unchanged root and an immutable read cache do not prove that metadata is safe to delete. Host admission coverage needs direct tests before any collection work.
Change
Four deterministic workerd tests pause actual HTTP and alarm reads at R2, on both success and failure. HTTP holds
graspBusy, refuses competing Git requests, signed event writes and HTTP management, and defers alarm storage work. Alarm holdsgraspControlsand refuses Git, but still admits a signed repository-state event into SQL purgatory without an R2 operation. Both paths release their flags; consuming the completed HTTP response performs no more R2 reads in this fixture.The cost documentation inventories HTTP, accepted-state/promotion, event/import/pull, management, alarm/expiry, teardown and direct helper coordination. It records remaining collection blockers: incomplete exclusion, unpublished writes and older readers, instance recovery, bounded complete inventories, and deletion coordination. The accepted event demonstrates an incomplete general lock, not an existing Git publication or data-loss bug.
This is the host half of the user's separate test/docs-only follow-up with the ntig task. The backend owns bounded source-only inventory and reader/publisher counterexamples. No runtime code, artifact, deployment, migration, collection, rate or tenant-usage change. No production operation or wake is added.
Testing Completed
npm run typecheckpasses.npm test: all 200 tests pass locally, including four new interleaving tests.Responsible AI disclosure
Codex authored the tests and documentation. A second agent reviewed entry-point coverage, and the ntig task independently checks backend inventory and coordination counterexamples.