Skip to content

style(teensy): rustfmt flash.rs — unblock the Formatting CI gate#972

Merged
zackees merged 1 commit into
mainfrom
fix/fmt-main
Jul 5, 2026
Merged

style(teensy): rustfmt flash.rs — unblock the Formatting CI gate#972
zackees merged 1 commit into
mainfrom
fix/fmt-main

Conversation

@zackees

@zackees zackees commented Jul 5, 2026

Copy link
Copy Markdown
Member

The Formatting workflow (soldr cargo fmt --all -- --check) has been red on main since #968 (760b40b), which merged an unformatted .map(...).unwrap_or_default() chain in crates/fbuild-deploy/src/teensy/flash.rs:125. That fails the Formatting check on every PR opened since.

cargo fmt --all reformats the one chain across lines; cargo fmt --all -- --check is now clean (0 diffs). No behavior change — whitespace only.

Diff in .../teensy/flash.rs:125:
-            flash_cwd.map(|p| p.display().to_string()).unwrap_or_default()
+            flash_cwd
+                .map(|p| p.display().to_string())
+                .unwrap_or_default()

🤖 Generated with Claude Code

#968 landed an unformatted `.map(...).unwrap_or_default()` chain in
teensy/flash.rs:125, turning the repo-wide Formatting check red on main
(failing for every PR since). `cargo fmt --all` reformats it; the check
is green again.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 48559023-93a6-416c-b26c-b02bee93895a

📥 Commits

Reviewing files that changed from the base of the PR and between e8eca79 and 3bf39d8.

📒 Files selected for processing (1)
  • crates/fbuild-deploy/src/teensy/flash.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/fmt-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees zackees merged commit 6e56db4 into main Jul 5, 2026
91 of 93 checks passed
@zackees zackees deleted the fix/fmt-main branch July 5, 2026 19:20
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant