Repository navigation
ci: build the Qt client and pass the frontend tests again - #120
Merged
Merged
Conversation
qt6ui never learned about Authenticate's new `device` field; it logs in as no device in particular, like a stock client. The admin page test still expected the list from before the invites page. accountSync's record listener rejected outside Tauri and left eight unhandled errors that failed vitest on their own; it now logs and carries on, as the screenshare listener does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes CI on
develop, which has been red since it last ran in June and blocks unrelated PRs such as #114.Changes
Authenticategained adevicefield (2c37c48); the Qt client now passesdevice: None, logging in as no particular device like a stock client.invitespage added in f012bbf.listen()rejects outside Tauri, and the eight unhandled rejections failed vitest even though every test passed. The listener now logs and carries on, as the screenshare hook's listener does.The integration tests need the Docker Mumble server and are left to CI.
cargo buildof qt6ui also passes locally.Checklist
cargo clippy --workspace -- -D warnings)npx tsc --noEmit)npm test)cargo test --package mumble-protocol --features opus-codec --lib)🤖 Generated with Claude Code