Repository navigation
nebula: scrolling back mounts the history it just fetched again - #116
Merged
Merged
Conversation
The window is left where it is on a prepend, as it always was: every index has shifted, so a window that does not move is looking at the rows that arrived. Moving it with them pinned the reader to the same messages and paged in history they could never reach. Only the false "N new messages" announcement is suppressed now, and only on positive evidence.
SetZero
added a commit
to GItwsa/FancyMumble
that referenced
this pull request
Sep 28, 2026
nebula: scrolling back mounts the history it just fetched again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression on
develop: after the message list learned to tell a page of fetched history from new arrivals, scrolling back fetched the older page but never showed it.The render window was being moved along with a prepend. Every index shifts when history is added at the front, so a window that stays where it is already looks at the rows that just arrived; moving it with them pinned the reader to the same messages and paged in history they could never reach. The window is left alone on a prepend again, as it always was. What stays from the earlier change is the part that was right: the false "N new messages" pill is suppressed for a prepend, and only on positive evidence that it was one.
Touches
MessageList.tsxand its test only. The unit suite was green with the regression in place - it was the end-to-end suite driving the real client that caught it - so the test added here asserts that the fetched rows are actually mounted.Expect this PR's first CI run to be red for reasons that are not in it:
developdoes not yet have the CI fixes from #115 (format gate on a CRLF checkout, clippy 1.98, two platform-dependent tests). It goes in after #115, updated onto it.