EXIT_ERROR macro requires do-while()

[not-kaz]

Hi,

I believe the EXIT_ERROR/EXIT_RETURN macros should be wrapped in a do-while(0) loop.
At the moment the macro cannot be used in an if/else statement and the trailing semi-colon is unnecessary.

#define EXIT_ERROR(...) do { fprintf(stderr, VA_ARGS); exit(1) } while (0)

[Falconerd]

Hey @not-kaz can you let me know your OS and terminal? I haven't got any issue on Windows with this macro, inside or outside of an if/else statement.

[not-kaz]

Hey @Falconerd,

Easiest example I've managed to find is in no-braces if/else statements.

if (!file_vertex.is_valid)  
    ERROR_EXIT("Error reading shader: %s\n", path_vert);  
else  
    fprintf(stdout, "Success\n"); 

On gcc this fails as 'else without previous if' and the ';' on the macro is regarded as an empty statement.

I'll just provide a quick google search result to hopefully explain better than me :)
https://hownot2code.wordpress.com/2016/12/05/do-while-0-in-macros/

[Falconerd]

Thanks, I will take a look :)