Harden release workflow tag handling#14
Open
NateIsern wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
${{ github.ref_name }}was interpolated directly into multi-linerun:scripts during packaging, allowing crafted tag names to execute commands on runners.Description
permissions: contents: readand preservecontents: writeonly on thecreate-releasejob to minimize token privileges.Validate release tagstep to each build job that setsTAG_NAMEfrom${{ github.ref_name }}and rejects tags that do not match a strict SemVer regex.TAG_NAME), constructpackage_dirvariables and quote all shell expansions to avoid shell interpolation of untrusted input.if: always()so the release job only runs after successful builds.Testing
python3regex validation with representative valid and invalid tags and it passed.YAML.load_file) and it parsed successfully.git diff --checkto ensure no whitespace/errors and it reported clean results.Codex Task