Repository navigation
Added multipart upload support, updated schema - #395
Merged
Merged
Conversation
nbutler77
commented
Oct 14, 2026
nbutler77
commented
Contributor
- Updated the media.upload functionality to split files into multiple parts, where necessary
- Updated generated API artifacts
There was a problem hiding this comment.
🟡 Changes recommended
A missing math import causes media uploads to fail before sending file data.
1 open finding
What changed in this PR
Adds multipart media uploads to the Conservator client and refreshes generated API artifacts.
Changes:
- Splits large uploads into streamed parts and collects completion tags.
- Adds annotation identity fields and mutations to the generated schema.
- Updates the API version marker.
| File | Description |
|---|---|
| FLIR/conservator/wrappers/media.py | Splits uploads into numbered parts. |
| FLIR/conservator/generated/schema.py | Adds identity fields and mutations. |
| FLIR/conservator/file_transfers.py | Supports streaming file slices by offset and length. |
| api_version.txt | Updates the API revision. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SJLC
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.