Repository navigation
chore(mypy): check against Python 3.12 - #4
Merged
Merged
Conversation
workshop only configured mypy overrides (pyarrow) and no base section, so the target version was whatever interpreter ran mypy. flow, distributed, carpenter, curator, render, cli and the fasthep metapackage pin python_version = 3.12; this aligns workshop with them. The supported Python versions stay as they are (>=3.11). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workshop only configured mypy overrides (for
pyarrow) and had no base section, so the target version was whatever interpreter ran mypy. flow, distributed, carpenter, curator, render, cli and thefasthepmetapackage pinpython_version = 3.12; this aligns workshop with them.requires-python(>=3.11) and the CI matrix are unchanged.Evidence
mypy src testson an export oforigin/mainand of this branch, same environment):sinks/table.py) and unrelated to the target version. The change only fixes the target.Merge Danger
Door: two-way. Three lines in
pyproject.toml.Blast Radius: type checking only. mypy output is unchanged today; the version no longer depends on the interpreter that runs it.
AI assistance
>=3.11) are unchanged and will be decided after the next release set.🤖 Generated with Claude Code