Skip to content

chore(mypy): check against Python 3.12 - #4

Merged
kreczko merged 1 commit into
mainfrom
chore/mypy-python-312
Oct 23, 2026
Merged

kreczko merged 1 commit into
mainfrom
chore/mypy-python-312

Conversation

@kreczko

@kreczko kreczko commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Summary

+[tool.mypy]
+python_version = "3.12"
+
 [[tool.mypy.overrides]]
 module = ["pyarrow", "pyarrow.*"]
 ignore_missing_imports = true

workshop only configured mypy overrides (for pyarrow) and had no base section, so the target version was whatever interpreter ran mypy. flow, distributed, carpenter, curator, render, cli and the fasthep metapackage pin python_version = 3.12; this aligns workshop with them. requires-python (>=3.11) and the CI matrix are unchanged.

Evidence

  • Before and after (mypy src tests on an export of origin/main and of this branch, same environment):
    src/fasthep_workshop/sinks/table.py:9: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
    Found 1 error in 1 file (checked 19 source files)
    
    The result is identical: the one error is pre-existing (a missing import in sinks/table.py) and unrelated to the target version. The change only fixes the target.

Merge Danger

Door: two-way. Three lines in pyproject.toml.

Blast Radius: type checking only. mypy output is unchanged today; the version no longer depends on the interpreter that runs it.

AI assistance

  • Generated: the change and this description were written with Claude Sonnet 5.5.
  • Reviewed: the author reviewed the diff locally before pushing. The checks above were run locally; the GitHub workflows have not run yet.
  • Design decision: the mypy target moves to 3.12 only; the supported Python versions (>=3.11) are unchanged and will be decided after the next release set.
  • Known limitations: none beyond the pre-existing items named above.

🤖 Generated with Claude Code

workshop only configured mypy overrides (pyarrow) and no base section, so the target
version was whatever interpreter ran mypy. flow, distributed, carpenter, curator, render,
cli and the fasthep metapackage pin python_version = 3.12; this aligns workshop with them.
The supported Python versions stay as they are (>=3.11).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kreczko
kreczko merged commit 85eb3f4 into main Oct 23, 2026
0 of 2 checks passed
@kreczko
kreczko deleted the chore/mypy-python-312 branch October 23, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant