Skip to content

Bookster - code review #10

Description

@JasonWarrenUK

README

IT DOES THESE THINGS YES NEXT

User stories

  • Interesting mashup of data
  • Change display with input
  • [/] Responsive Design
  • [/] Indication that it's loading
  • Indication that there's a problem

Learning outcomes

Most of this is done, haven't had time to go through 95 js files to check array methods but life is a precious thing that should be treasured and crucially I trust your intentions so there's that.

UI bugs

  • Footer has inconsistent sizing on:
    • Main page
    • Result page
    • Error page

Instructions

IT WORKS

File structure

It's a glorious jumble of wishes and whimsies, but I think I can guess what each of these 74 files do

Flow of control

[ Can you you follow the different paths the code might take?]

Naming

[Do variables and functions have clear and descriptive names?]

Readability

[Do you understand the code?]

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions