Fix external WordPress WP-CLI global flag ordering - #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--userand--pathWP-CLI globals before caller subcommand argumentsCloses #367.
Verification
bash tests/external-wordpress-runtime.shbun tests/kimaki-session-attribution.mjsgit diff --check671f1c93c945abcdb826a71c34c0de2f7c7bf879passed both durable gates in runcook-detached-2186c97b-f85f-4bd7-92e7-1a4ccffb1b7c-attempt-2-664612b0. Finalization was completed directly because Homeboy #12225 blocked reviewer-metadata recovery after the green promotion.Compatibility
The wrapper retains transport-prefix and embedded-whitespace handling while producing WP-CLI-compatible global argument order. The Bash parser now supports the macOS-provided Bash 3.2 instead of requiring
mapfile. Kimaki lookups remain bounded and cached; only the startup allowance changes from two to five seconds.AI Assistance
OpenAI
gpt-5.6-terraandgpt-5.6-solvia OpenCode implemented, reviewed, and verified the change. Chris Huber reviewed and remains responsible for every line.