Skip to content

[No QA][LegendList 11/15] chore: rebuild the LegendList patches from their upstream PRs #106626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrispader wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[No QA][LegendList 11/15] chore: rebuild the LegendList patches from their upstream PRs #106626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32a035e
chore: rebuild the LegendList patches from their upstream PRs
chrispader Nov 11, 2026
16a575a
docs: note LegendList's new anchor offset in the Android MVCP patch n…
chrispader Nov 11, 2026
92b6fbe
fix: keep native list content in place when a LegendList header resizes
chrispader Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 56 additions & 4 deletions patches/@legendapp/list/@legendapp+list+3.7.2+001+apply-pending-anchor-correction.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,57 @@
diff --git a/node_modules/@legendapp/list/react-native.js b/node_modules/@legendapp/list/react-native.js
index 4af685dfb96..92b387b085f 100644
--- a/node_modules/@legendapp/list/react-native.js
+++ b/node_modules/@legendapp/list/react-native.js
@@ -4769,7 +4769,8 @@ function calculateItemsInView(ctx, params = {}) {
const stickyHeaderIndicesArr = state.props.stickyHeaderIndicesArr || [];
const stickyHeaderIndicesSet = state.props.stickyHeaderIndicesSet || /* @__PURE__ */ new Set();
const drawDistance = getEffectiveDrawDistance(ctx, params.drawDistanceMode);
- const { dataChanged, doMVCP, forceFullItemPositions, mvcpAdjustmentSource } = params;
+ const { dataChanged, forceFullItemPositions } = params;
+ let { doMVCP, mvcpAdjustmentSource } = params;
const bootstrapInitialScrollState = ((_a3 = state.initialScrollSession) == null ? void 0 : _a3.kind) === "bootstrap" ? state.initialScrollSession.bootstrap : void 0;
const suppressInitialScrollSideEffects = !!bootstrapInitialScrollState;
const prevNumContainers = peek$(ctx, "numContainers");
@@ -4869,6 +4870,11 @@ function calculateItemsInView(ctx, params = {}) {
}
}
}
+ if (!doMVCP && state.scheduledWork.has("mvcpRecalculate")) {
+ state.scheduledWork.cancel("mvcpRecalculate");
+ doMVCP = true;
+ mvcpAdjustmentSource = "item-size";
+ }
const checkMVCP = doMVCP && !suppressInitialScrollSideEffects ? prepareMVCP(ctx, dataChanged, mvcpAdjustmentSource) : void 0;
if (dataChanged) {
resetLayoutCachesForDataChange(state);
diff --git a/node_modules/@legendapp/list/react-native.mjs b/node_modules/@legendapp/list/react-native.mjs
index 9ebfddc183a..30105d17d72 100644
--- a/node_modules/@legendapp/list/react-native.mjs
+++ b/node_modules/@legendapp/list/react-native.mjs
@@ -4748,7 +4748,8 @@ function calculateItemsInView(ctx, params = {}) {
const stickyHeaderIndicesArr = state.props.stickyHeaderIndicesArr || [];
const stickyHeaderIndicesSet = state.props.stickyHeaderIndicesSet || /* @__PURE__ */ new Set();
const drawDistance = getEffectiveDrawDistance(ctx, params.drawDistanceMode);
- const { dataChanged, doMVCP, forceFullItemPositions, mvcpAdjustmentSource } = params;
+ const { dataChanged, forceFullItemPositions } = params;
+ let { doMVCP, mvcpAdjustmentSource } = params;
const bootstrapInitialScrollState = ((_a3 = state.initialScrollSession) == null ? void 0 : _a3.kind) === "bootstrap" ? state.initialScrollSession.bootstrap : void 0;
const suppressInitialScrollSideEffects = !!bootstrapInitialScrollState;
const prevNumContainers = peek$(ctx, "numContainers");
@@ -4848,6 +4849,11 @@ function calculateItemsInView(ctx, params = {}) {
}
}
}
+ if (!doMVCP && state.scheduledWork.has("mvcpRecalculate")) {
+ state.scheduledWork.cancel("mvcpRecalculate");
+ doMVCP = true;
+ mvcpAdjustmentSource = "item-size";
+ }
const checkMVCP = doMVCP && !suppressInitialScrollSideEffects ? prepareMVCP(ctx, dataChanged, mvcpAdjustmentSource) : void 0;
if (dataChanged) {
resetLayoutCachesForDataChange(state);
diff --git a/node_modules/@legendapp/list/react-native.web.js b/node_modules/@legendapp/list/react-native.web.js
index 5155454..c102661 100644
index 515545471e0..c102661fc18 100644
--- a/node_modules/@legendapp/list/react-native.web.js
+++ b/node_modules/@legendapp/list/react-native.web.js
@@ -4843,7 +4843,8 @@ function calculateItemsInView(ctx, params = {}) {
Expand All @@ -25,7 +77,7 @@ index 5155454..c102661 100644
if (dataChanged) {
resetLayoutCachesForDataChange(state);
diff --git a/node_modules/@legendapp/list/react-native.web.mjs b/node_modules/@legendapp/list/react-native.web.mjs
index ce08abe..ff71fd6 100644
index ce08abe7ee6..ff71fd62640 100644
--- a/node_modules/@legendapp/list/react-native.web.mjs
+++ b/node_modules/@legendapp/list/react-native.web.mjs
@@ -4822,7 +4822,8 @@ function calculateItemsInView(ctx, params = {}) {
Expand All @@ -51,7 +103,7 @@ index ce08abe..ff71fd6 100644
if (dataChanged) {
resetLayoutCachesForDataChange(state);
diff --git a/node_modules/@legendapp/list/react.js b/node_modules/@legendapp/list/react.js
index 5155454..c102661 100644
index 515545471e0..c102661fc18 100644
--- a/node_modules/@legendapp/list/react.js
+++ b/node_modules/@legendapp/list/react.js
@@ -4843,7 +4843,8 @@ function calculateItemsInView(ctx, params = {}) {
Expand All @@ -77,7 +129,7 @@ index 5155454..c102661 100644
if (dataChanged) {
resetLayoutCachesForDataChange(state);
diff --git a/node_modules/@legendapp/list/react.mjs b/node_modules/@legendapp/list/react.mjs
index ce08abe..ff71fd6 100644
index ce08abe7ee6..ff71fd62640 100644
--- a/node_modules/@legendapp/list/react.mjs
+++ b/node_modules/@legendapp/list/react.mjs
@@ -4822,7 +4822,8 @@ function calculateItemsInView(ctx, params = {}) {
Expand Down
Loading
Loading