[No QA] Keep unread markers on visible support replies by roryabraham · Pull Request #105979 · Expensify/App

roryabraham · 2026-11-04T20:38:11Z

Explanation of Change

An old support-ticket survey can take the unread marker even though the survey itself is hidden, leaving an unread reply without a “New” divider. Filter hidden surveys before unread selection, keeping both content-level action arrays aligned without changing pagination or loading decisions.

Fixed Issues

For #105473

Tests

Sign in with a test account, and click Home.

Open Chrome’s developer tools with Option+Command+J on macOS (Ctrl+Shift+J on Windows/Linux), select Console, and run the fixture below. It creates a local test conversation and puts the app in offline mode; it does not create a server-side support ticket.

async function seedSurveyUnreadTicket(state = 'unresolved') {
    await Onyx.merge('network', {isOffline: true});
    const {accountID} = await Onyx.get('session');
    const reportID = '991105473';
    const makeAction = (id, actionName, minute, text) => ({
        reportActionID: String(id), actionName, created: `2026-11-04 10:${minute}:00.000`,
        actorAccountID: 8392101, message: [{type: 'COMMENT', text, html: text}],
        originalMessage: {html: text}, shouldShow: true,
    });
    const actions = [
        makeAction(991105470, 'CREATED', '00', 'Support ticket opened'),
        makeAction(991105471, 'ADDCOMMENT', '01', 'Previously read message'),
        makeAction(991105472, 'SUPPORT_SURVEY', '03', 'Obsolete survey'),
        makeAction(991105473, 'ADDCOMMENT', '04', 'Your support reply after reopening'),
    ];
    if (state !== 'unresolved') {
        if (state !== 'missing-closure') actions.push(makeAction(991105474, 'CLOSED', '05', 'Resolved support ticket'));
        actions.push(makeAction(991105475, 'SUPPORT_SURVEY', '06', 'Latest support survey'));
    }
    await Onyx.multiSet({
        [`report_${reportID}`]: {
            reportID, type: 'supportTicket', reportName: 'Survey unread regression', ownerAccountID: accountID, managerID: 8392101,
            stateNum: state === 'unresolved' ? 0 : 2, statusNum: state === 'unresolved' ? 0 : 2,
            participants: {[accountID]: {notificationPreference: 'always'}, 8392101: {notificationPreference: 'always'}},
            lastReadTime: '2026-11-04 10:02:00.000', lastVisibleActionCreated: actions.at(-1).created,
            lastMessageText: actions.at(-1).message[0].text,
        },
        [`reportActions_${reportID}`]: Object.fromEntries(actions.map(action => [action.reportActionID, action])),
        [`reportActionsPages_${reportID}`]: [actions.map(action => action.reportActionID).reverse()],
        [`reportNameValuePairs_${reportID}`]: state === 'replaced' ? {reopenedAsReportID: '991105480'} : {},
        [`reportLoadingState_${reportID}`]: {hasOnceLoadedReportActions: true, isLoadingInitialReportActions: false},
    });
    history.pushState({}, '', `/r/${reportID}`);
    window.dispatchEvent(new PopStateEvent('popstate'));
}
await seedSurveyUnreadTicket();

Confirm “Your support reply after reopening” has exactly one “New” divider above it, and no “How was your support experience?” survey is displayed.
Click Home, then run await seedSurveyUnreadTicket('resolved') in Console.
Confirm the reply still has its “New” divider and exactly one “How was your support experience?” survey appears below “Resolved support ticket”.
Click Home, then run await seedSurveyUnreadTicket('replaced') in Console.
Confirm the survey disappears and the reply retains its “New” divider.
Click Home, then run await seedSurveyUnreadTicket('missing-closure') in Console.
Confirm no survey appears when the resolution message is not cached, and the reply retains its “New” divider.

Verify that no errors appear in the JS console

Offline tests

The local fixture above exercises the list with the app in offline mode. Server persistence and native platforms are not covered by these steps.

QA Steps

None.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-11-04.at.4.20.44.PM.mov

chatgpt-codex-connector · 2026-11-04T20:45:28Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-05T00:26:52.600736Z	`7f79652`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector · 2026-11-04T21:13:34Z

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 0d6b5ed4db

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-11-05T00:22:55Z

@justinpersaud Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

App/src/pages/inbox/report/ReportActionsList/ReportActionsListContent.tsx

Line 150 in 7f79652

sortedVisibleReportActions,

Keep hidden surveys in mark-as-read catch-up

When an unresolved or replaced support ticket remains mounted while the window is unfocused and its only new action is a hidden survey, passing this filtered array to useMarkAsRead prevents the focus-recovery scan from finding any unread action. The report-change pass records a skipped read, but there is no rendered unread row to trigger completeSkippedMarkAsRead(), so lastReadTime is not advanced and the report can remain unread in the LHN after focus returns. Preserve the unfiltered page for useMarkAsRead while using the filtered arrays for unread-marker selection and rendering.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

github-actions · 2026-11-05T23:31:33Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-11-05T23:35:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-11-05T23:37:10Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #105979 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ca844d48-eb6e4a2-54e61c4a76ce295bd103aefd8cfccdf150aa38fd/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ca844d48-eb6e4a2-f9dea89be511ca1e145bed42dcf5cc8b3c7de84b/index.html

Web 🕸️
https://105979.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-11-06T09:12:18Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-11-06T09:14:47Z

No FullStory changes needed — this PR only fixes unread-divider placement by excluding already-hidden support surveys before unread selection; it adds no new user-facing functionality.

OSBotify · 2026-11-07T20:59:06Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.5.33-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

roryabraham added 2 commits November 4, 2026 12:25

test: reproduce hidden survey unread marker loss

5c09e64

fix: filter support surveys before unread selection

a025e65

roryabraham requested a review from a team November 4, 2026 20:38

melvin-bot Bot assigned roryabraham Nov 4, 2026

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

This comment was marked as low quality.

Sign in to view

fix: preserve scroll freshness for hidden surveys

0d6b5ed

This comment has been minimized.

Sign in to view

Merge branch 'main' into rory/fix-support-survey-unread

7f79652

roryabraham changed the title ~~Keep unread markers on visible support replies~~ [No QA] Keep unread markers on visible support replies Nov 5, 2026

roryabraham marked this pull request as ready for review November 5, 2026 00:22

roryabraham requested a review from a team as a code owner November 5, 2026 00:22

melvin-bot Bot requested review from justinpersaud and trjExpensify and removed request for a team November 5, 2026 00:22

chatgpt-codex-connector Bot reviewed Nov 5, 2026

View reviewed changes

justinpersaud approved these changes Nov 5, 2026

View reviewed changes

roryabraham merged commit ca844d4 into main Nov 5, 2026
53 of 56 checks passed

roryabraham deleted the rory/fix-support-survey-unread branch November 5, 2026 23:31

OSBotify mentioned this pull request Nov 6, 2026

Deploy Checklist: New Expensify 2026-11-06 #106177

Closed

93 tasks done

Conversation

roryabraham commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

This comment has been minimized.

This comment has been minimized.

chatgpt-codex-connector Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as low quality.

This comment has been minimized.

chatgpt-codex-connector Bot commented Nov 4, 2026

Uh oh!

melvin-bot Bot commented Nov 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions Bot commented Nov 5, 2026

Uh oh!

OSBotify commented Nov 5, 2026

Uh oh!

github-actions Bot commented Nov 5, 2026

Uh oh!

OSBotify commented Nov 6, 2026

Uh oh!

MelvinBot commented Nov 6, 2026

Uh oh!

OSBotify commented Nov 7, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

roryabraham commented Nov 4, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 4, 2026 •

edited

Loading