Repository navigation
test: fix flaky ListenerUtilsTest.error log assertion - #152
Open
jamespfaulkner wants to merge 1 commit into
Open
jamespfaulkner wants to merge 1 commit into
jamespfaulkner wants to merge 1 commit into
Conversation
The root-logger appender could capture unrelated log events, breaking the single-event assertion and failing the 8.2.7 release prepare. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListenerUtilsTest.errorwas flaky. It attaches a capturing appender to the root log4j logger and asserts exactly one event was logged, so any unrelated log line emitted during the test (e.g. from Hive/metrics initialisation) broke thehasSize(1)assertion (Expected size:<1> but was:<2>).release:prepare(run 37761949794) and run 37759064276 earlier, with no related code changes.ListenerUtilsbefore asserting. Production code is unchanged.### Fixedentry under 8.2.7 inCHANGELOG.md.Test plan
ListenerUtilsTestpasses locally (mvn -pl apiary-metastore-events/kafka-metastore-events/kafka-metastore-listener -am test -Dtest=ListenerUtilsTest)🤖 Generated with Claude Code