Repository navigation
feat: send Glue VersionId on Hive table updates (GLUE_SEND_VERSION_ID) #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jamespfaulkner
merged 7 commits into
main
from
feat/gluesync-send-versionid-single-attempt
Oct 8, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
017d281
feat: send Glue VersionId on Hive table updates (GLUE_SEND_VERSION_ID)
jamespfaulkner cf12700
docs: make MAX_VERSION_ID_ATTEMPTS comment a javadoc
jamespfaulkner c9a109e
fix: degrade to unconditional update when Glue VersionId cannot be read
jamespfaulkner ea9b70a
refactor: make OptimisticUpdateRetry generic; drop mutable-holder out…
jamespfaulkner 25e0789
refactor: single-attempt versionId update with unconditional fallback
jamespfaulkner 97b15dd
test: cover all listener flows with GLUE_SEND_VERSION_ID enabled
jamespfaulkner af8e3d0
refactor: send versionId for all table types; keep skip-archive untou…
jamespfaulkner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
...main/java/com/expediagroup/apiary/extensions/gluesync/listener/service/DeleteOutcome.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /** | ||
| * Copyright (C) 2018-2026 Expedia, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.expediagroup.apiary.extensions.gluesync.listener.service; | ||
|
|
||
| /** | ||
| * Outcome of a {@link GlueTableService#deleteIfUnchanged} call, used by callers to record the | ||
| * appropriate metric. | ||
| * <ul> | ||
| * <li>{@code DELETED} — the Glue table was deleted.</li> | ||
| * <li>{@code SKIPPED} — the delete was suppressed because identity params diverged, indicating | ||
| * the Glue slot was overwritten by a concurrent operation.</li> | ||
| * <li>{@code NOT_FOUND} — the table did not exist in Glue when checked; nothing to delete.</li> | ||
| * <li>{@code DELETED_CONCURRENTLY} — the table existed at guard-check time but was deleted by a | ||
| * concurrent operation before the delete call completed (TOCTOU race).</li> | ||
| * </ul> | ||
| */ | ||
| public enum DeleteOutcome { | ||
| DELETED("deleted"), | ||
| SKIPPED("delete_skipped"), | ||
| NOT_FOUND("not_found"), | ||
| DELETED_CONCURRENTLY("concurrent_delete"); | ||
|
|
||
| private final String metricOutcome; | ||
|
|
||
| DeleteOutcome(String metricOutcome) { | ||
| this.metricOutcome = metricOutcome; | ||
| } | ||
|
|
||
| public String metricOutcome() { | ||
| return metricOutcome; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why glue table calls glue partition serivce for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already there. Just now rather than creating a boolean its inlined