Suppress expected jwst_gtvt future-date ERFA warnings locally

[taylorbell57]

Closes #716

jwst_gtvt validates its internal future maximum date while constructing an ephemeris, producing an ERFA dubious year warning even when the requested visibility period is earlier.

This change suppresses only that expected warning, only during ephemeris construction. A regression test verifies that unrelated ERFA warnings remain visible.

Tests: pytest exoctk/tests/test_contam_visibility.py -q -k 'new_vis_plot or visibility_ephemeris_suppresses'

[Copilot]

Pull request overview

This PR addresses noisy ERFA dubious year warnings emitted during jwst_gtvt ephemeris construction by adding a narrowly scoped warning suppression around BoundedEphemeris() construction, plus a regression test ensuring unrelated ERFA warnings are still surfaced to callers.

Changes:

• Locally suppress the specific ERFA dtf2d “dubious year (Note 6)” warning only during BoundedEphemeris construction.
• Add a regression test that verifies the expected warning is suppressed while unrelated ErfaWarnings remain visible.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
exoctk/contam_visibility/new_vis_plot.py	Adds a tightly scoped warnings filter around ephemeris construction to ignore only the expected ERFA “dubious year” warning.
exoctk/tests/test_contam_visibility.py	Adds a regression test to ensure only the expected ERFA warning is suppressed and unrelated ERFA warnings still propagate.

Suppressed comments (1)

exoctk/tests/test_contam_visibility.py:249

• After restricting the capture to ErfaWarning, the assertion can be simplified; using w.message also avoids relying on the local variable name warning and keeps the expression concise.

    assert [str(warning.message) for warning in caught] == [
        'unrelated ERFA warning']

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.