Skip to content

Answer label creation with 201 without Location - #690

Merged
vdolek merged 2 commits into
masterfrom
claude/project-thread-fyo2wf-labels
Oct 31, 2026
Merged

vdolek merged 2 commits into
masterfrom
claude/project-thread-fyo2wf-labels

Conversation

@EvilBrainsBot

@EvilBrainsBot EvilBrainsBot commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Requested by Martin · project thread

Summary

POST /api/labels answers 201 Created without a Location header, because a label has no detail endpoint. Follows the owner's decision on #682, which does the same for API tokens.

Changes

  • LabelsController.CreateLabel returns 201 with the created label and no Location.
  • SDD-005 merges the API token exception into one sentence for records without a detail endpoint: API tokens and labels.
  • CreateLocationTests asserts label creation answers 201 without Location.

https://claude.ai/code/session_01UovdganawgyqDHGsank6jS


Generated by Claude Code

@EvilBrainsBot
EvilBrainsBot requested a review from vdolek as a code owner October 30, 2026 21:25
@EvilBrainsBot EvilBrainsBot added the agent-in-progress An agent is working on this pull request label Oct 30, 2026 — with Claude
@EvilBrainsBot EvilBrainsBot self-assigned this Oct 30, 2026

Copy link
Copy Markdown
Member Author

Code Review

  • Added a CreateLocationTests case asserting that label creation answers 201 without Location.

Generated by Claude Code

@EvilBrainsBot EvilBrainsBot removed the agent-in-progress An agent is working on this pull request label Oct 30, 2026
@EvilBrainsBot EvilBrainsBot added the agent-done Waiting for the owner's review and merge label Oct 30, 2026 — with Claude
vdolek
vdolek previously approved these changes Oct 30, 2026
A label has no detail endpoint, so the created response carries no Location; SDD-005 names the exception.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UovdganawgyqDHGsank6jS
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UovdganawgyqDHGsank6jS
@vdolek
vdolek merged commit 8005f06 into master Oct 31, 2026
2 checks passed
@vdolek
vdolek deleted the claude/project-thread-fyo2wf-labels branch October 31, 2026 12:41
@github-actions github-actions Bot removed the agent-done Waiting for the owner's review and merge label Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants