Make SpriteBank.orig_ctor throw a descriptive error if an element has copy but no path#1100
Open
SilverDorian46 wants to merge 1 commit into
Open
Conversation
… `copy` but no `path`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpriteData.Addalready throws an error with the message"Sprite '" + xmlElement.Name + "': 'path' is missing!",but in order to do that, the execution has to enter
SpriteData.Addfirst.at the moment, if the element has
copy, then the execution tries to get the value ofpaththroughxmlElement.Attr("path")- which doesn't do a null check - and pass it toSpriteData.Add, which happens beforeSpriteData.Additself is executed.hence, if the element has
copybut nopath, the program throws a vague NullReferenceException.this PR patches that for the program to check
xmlElement.HasAttr("path"), which is essentially a null check, right before the line where it tries to getxmlElement.Attr("path").if the check returns false, an exception with the message
"Sprite '" + xmlElement.Name + "': 'path' is missing!"is thrown.