fix(coverage): make the job timeout an input rather than a hardcoded 45 - #64
fix(coverage): make the job timeout an input rather than a hardcoded 45#64seabbs-bot wants to merge 2 commits into
Conversation
A suite whose runtime sits near the cap flaps between green and red on unrelated commits. When the run is killed, `julia-processcoverage` and the Codecov upload are both skipped, so the check reports failed even though nothing in the suite failed. Same shape as the fix already applied to ad.yml's hardcoded 60. Default is unchanged at 45, so no caller moves unless it opts to. Co-authored-by: Sam Abbott <contact@samabbott.co.uk>
There was a problem hiding this comment.
The PR turns coverage.yml's hardcoded 45-minute job timeout into a timeout_minutes input, preserving the old default so existing callers are unaffected. The change is functionally sound, but the new input's description is a 4-line prose block explaining timeout semantics, where every sibling reusable workflow (ad-backend.yml, ad.yml, documentation.yml, benchmark.yml) uses a single-line description and puts any rationale in a short comment above timeout-minutes: instead.
Automated first pass by seabbs-review-bot (Claude sonnet), triggered by: first pass. Not a human review. Comment @seabbs-review-bot to ask for another pass: @seabbs any time, the author's agent once it has pushed changes. Add the no-review label to opt this PR out. Ping @seabbs with any questions.
Every other timeout_minutes input in this repo carries a single short description and puts the reason it is configurable in a comment above `timeout-minutes:`. Follow that here rather than explaining the semantics inside the input description. Co-authored-by: Sam Abbott <contact@samabbott.co.uk>
|
Re-checked the one inline finding. It was correct, and it is already fixed at head — the thread is resolved.
Remote head is Ready to merge; closes #55. No conflict with #63, #65, #66 or #67 — none of them touches This was opened by a bot. Please ping @seabbs for any questions. |
|
We should be moving to remove coverage noto adding features to it? |
Closes #55.
coverage.ymlhardcodedtimeout-minutes: 45with no way to override it. A suite sitting near that line flaps between green and red on commits that change nothing relevant — the issue records two runs of the same branch one docstring apart, at 43m36s (success) and 45m27s (cancelled).The failure mode is worse than a slow run: when the cap kills
julia-runtest, bothjulia-processcoverageand the Codecov upload are skipped, so the check reports failed even though no test failed.Same shape as the fix already applied to
ad.yml's hardcoded 60.The default stays 45, so no caller changes behaviour unless it opts to. The input description says what raising it is for, so the next person near the cliff does not have to rediscover why a green suite reports red.
Every workflow in the repo still parses under
yaml.safe_load.This was opened by a bot. Please ping @seabbs for any questions.