137 bug passthrough does not enable on first button press - #141
Merged
ng-daniel merged 3 commits intoAug 31, 2026
Merged
Conversation
ng-daniel
marked this pull request as ready for review
August 28, 2026 17:28
arocull
approved these changes
Aug 28, 2026
arocull
left a comment
arocull
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thank you so much!
ng-daniel
deleted the
137-bug-passthrough-does-not-enable-on-first-button-press
branch
August 31, 2026 15:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently OnSetPassthrough isn't properly called on app startup, so directly calling it in the Start function initializes passthrough properly (this explains why it works after you flip the passthrough toggle a couple times, because then you do end up calling OnSetPassthrough for real). Also added an OnOcclusionMethodChange call for consistency.