Skip to content

fix: stabilize UI unit tests after SMART merge - #2005

Closed
benjaminpaige wants to merge 2 commits into
mainfrom
fix-main-ui-test-failures-after-smart-merge
Closed

fix: stabilize UI unit tests after SMART merge#2005
benjaminpaige wants to merge 2 commits into
mainfrom
fix-main-ui-test-failures-after-smart-merge

Conversation

@benjaminpaige

Copy link
Copy Markdown
Collaborator

Summary

  • Fix UI Vitest isolation so window.localStorage and global.localStorage share one mock (column prefs no longer leak across skipCleanup suites).
  • Nest/reset skipCleanup between files, harden dashboard column toggles, and run Deploy unit tests with --run plus Vitest --pool=forks.
  • Unblocks main Deploy test (and Release to val Release to val #2002) after the SMART outbound merge.

Test plan

  • ./run test --run on previously failing UI files (waivers, spas, renderCells, temporary-extension, DateRange, Opensearch main, dashboard)
  • Full ./run test --run — 348 files / 2700 tests passed
  • Confirm Deploy test job is green on this PR
  • After merge, confirm Release to val #2002 required checks clear (re-run if needed)

Align window/global localStorage in tests, reset skipCleanup between files, harden column toggles, and run CI unit tests with --run and forks so main Deploy checks stop flaking.
Satisfy simple-import-sort so pre-push lint passes.
@benjaminpaige
benjaminpaige had a problem deploying to fix-main-ui-test-failures-after-smart-merge September 2, 2026 15:30 — with GitHub Actions Failure
@benjaminpaige
benjaminpaige had a problem deploying to fix-main-ui-test-failures-after-smart-merge September 2, 2026 15:30 — with GitHub Actions Failure
@macpro-snyk-service-account

macpro-snyk-service-account commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@benjaminpaige

Copy link
Copy Markdown
Collaborator Author

Closing in favor of #2006.

Root cause was not Vitest isolation / skipCleanup leakage. CI was discarding the committed Bun lockfiles (error parsing lockfile: Outdated lockfile version under Bun 1.1.20) and re-resolving every semver range on every run. That floated UI deps after Aug 28 and hung the form unit tests (same tree that was green when CI floated to earlier versions).

#2006 pins react-hook-form to 7.86.0, bumps Bun to 1.4.0 so the lockfile is readable, and enforces --frozen-lockfile in CI. Deploy test is green there (348 files / 2700 tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants