fix: stabilize UI unit tests after SMART merge - #2005
Closed
benjaminpaige wants to merge 2 commits into
Closed
Conversation
Align window/global localStorage in tests, reset skipCleanup between files, harden column toggles, and run CI unit tests with --run and forks so main Deploy checks stop flaking.
Satisfy simple-import-sort so pre-push lint passes.
benjaminpaige
had a problem deploying
to
fix-main-ui-test-failures-after-smart-merge
September 2, 2026 15:30 — with
GitHub Actions
Failure
benjaminpaige
had a problem deploying
to
fix-main-ui-test-failures-after-smart-merge
September 2, 2026 15:30 — with
GitHub Actions
Failure
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
5 tasks
Collaborator
Author
|
Closing in favor of #2006. Root cause was not Vitest isolation / #2006 pins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.localStorageandglobal.localStorageshare one mock (column prefs no longer leak acrossskipCleanupsuites).skipCleanupbetween files, harden dashboard column toggles, and run Deploy unit tests with--runplus Vitest--pool=forks.test(and Release to val Release to val #2002) after the SMART outbound merge.Test plan
./run test --runon previously failing UI files (waivers, spas, renderCells, temporary-extension, DateRange, Opensearch main, dashboard)./run test --run— 348 files / 2700 tests passedtestjob is green on this PR