Repository navigation
0.19.0: dataset quality, identity policy, local multi-reference - #6
Merged
Merged
Conversation
…for ② - preprocess writes the isolated copy to prepped/refs/, PreprocessReport.reference - training copy is always the resized/restored original with its background - ① auto-fills ② with refs/ and ③ with the training folder - ① checkbox labels and notes describe the split - cli build generates from refs, captions training copies, adds --isolate-angles (default off) - cli preprocess echoes the refs folder - tests for the split, alpha refs and build wiring
- header radio for characters; Identity only dresses angle/pose shots and captions clothing - Signature costume keeps the reference outfit and leaves it out of captions - CaptionerSpec.prompt_for(identity=) appends the policy clause - caption_images/caption_folder/Captioner.caption take identity - wardrobe.dress shared by app plan table and cli - cli generate/caption/build --identity identity|costume; --randomize-outfits kept as alias - policy recorded in metadata.json for character datasets - tests
- Shot.framing (full / waist-up / close-up / tight-face); two poses waist-up, two close-ups tight face - framing column in the ② plan table - shotplan.coverage: kept-shot counts by framing, turnaround, expression, outfit with gap and dominance warnings - ② coverage line under the gallery with a dominance threshold field (default 40%) - isolate.touches_bottom; PreprocessReport.cut_off; ① note and cli warn when every reference is cut off - tests
- ② Find near-duplicates: kept shots that copy a reference, and near-identical kept shots (uses ④'s sensitivity) - ② shows the primary reference beside the gallery - dedupe.find_bursts groups real photos captured seconds apart; ④ preview names them - tests
…rence cap - ComfyUI engine: one LoadImage per reference wired to images.image_N, deduplicated, chain view first - Settings qwen21_max_refs (default 1) and qwen21_resolution (default 1536), with .env.example lines - ② "jump the queue" now reaches local generation (make_engine passes front) - Gemini: 2:3 for angle full-body shots, 1:1 for close-ups, unset otherwise - Gemini: references capped at the model's character limit (Pro 5, others 4), deduplicated - Tests for loader wiring, front, aspect and the reference cap
- generate_shots(anchor=): front full-body view runs first and leads every other shot's references - Chained views still lead; the anchor and the originals follow - ② "Anchor shot" checkbox and --anchor/--no-anchor on generate and build (default off) - Tests for anchor order and references, and for the unchanged default
- Model and processor cached together, so a processor 401 no longer turns the next image's error into "'NoneType' object is not callable" - Load error says when an HF_TOKEN overrides `hf auth login` - Test for the half-load case
- ARCHITECTURE: module map, alpha-cutout note, decisions for refs/ split, identity policy, framing and coverage, cut-off check, Gemini aspect and cap, anchor shot - README: identity policy, refs/ and coverage paragraph, CLI examples on prepped/refs, alpha note - ① exclude-prompt tooltip and CLI help: SAM3 keeps held objects, name them - ② angle-isolation tooltip states why it is off
- version 0.19.0; AGENTS.md current state - ARCHITECTURE: local ② A/B (refs 1 vs 2, 1024 vs 1536, anchor) and the defaults it set - anchor tooltip and CLI help: it copies the front view's mistakes, check that view first - config comment points at the A/B
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepped/refs/and is used only as ②'s referenceLDS_QWEN21_MAX_REFSreferences atLDS_QWEN21_RESOLUTION; ② "jump the queue" now reaches local generation--anchor)