Skip to content

2.4.1: audit fixes, lmstudio pinned to >=1.5.0,<2 - #28

Merged
EnragedAntelope merged 1 commit into
mainfrom
temp/audit-fixes
Nov 14, 2026
Merged

EnragedAntelope merged 1 commit into
mainfrom
temp/audit-fixes

Conversation

@EnragedAntelope

Copy link
Copy Markdown
Owner

Fixes from a full repo audit.

  • user_config.json saved with a BOM, as UTF-16, or holding null/a number no longer stops the node from loading (it falls back to defaults with a warning)
  • timeout_seconds of 0 or less falls back to 5 instead of being reported as "Invalid JSON"
  • server_host of [::1]:5000 no longer becomes [::1]:5000:1234
  • A response that starts with <think> and never closes it (out of tokens mid-thought) is returned as reasoning, not passed downstream as the answer
  • ComfyUI cancel now works while LM Studio is still reading the prompt (on_prompt_processing_progress); model load stays uncancellable
  • Very thin images (e.g. 4000x2) no longer fail the resize
  • Removed ensure_default_config_exists (never ran, since the file is tracked); default_config.json gains the missing api_token key
  • lmstudio>=1.5.0,<2: 1.5.0 is the only version exercised; 2.x needs a live run before allowing it. 1.6 prereleases (api_token) still fit.

Testing

  • pytest -q: 185 passed; pyflakes . clean
  • Live on the 8288 test instance with qwen3-4b-instruct-2507: text run succeeded and unloaded; an interrupted run reported execution_interrupted at 3.6s and unloaded the model
  • Direct SDK check: cancel from the progress callback stopped after 0.06s with 0 tokens (userStopped), against 2.67s to first token without it

- user_config.json: read as utf-8-sig, ignore non-object JSON, catch UTF-16 decode errors instead of failing node load
- timeout_seconds <= 0 falls back to 5 (was misreported as invalid JSON)
- server_host "[v6]:port" no longer doubles the port
- unclosed <think>-style tag at the start of a response goes to reasoning, not the response
- cancel now also fires during prompt processing via on_prompt_processing_progress
- resize keeps at least 1 px on very thin images
- remove never-run ensure_default_config_exists; add api_token to default_config.json
- lmstudio requirement >=1.5.0,<2 in pyproject.toml and requirements.txt
- tests for each fix; README and AGENTS.md updated
@EnragedAntelope
EnragedAntelope merged commit 11882be into main Nov 14, 2026
3 checks passed
@EnragedAntelope
EnragedAntelope deleted the temp/audit-fixes branch November 14, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant