Repository navigation
2.4.1: audit fixes, lmstudio pinned to >=1.5.0,<2 - #28
Merged
Merged
Conversation
- user_config.json: read as utf-8-sig, ignore non-object JSON, catch UTF-16 decode errors instead of failing node load - timeout_seconds <= 0 falls back to 5 (was misreported as invalid JSON) - server_host "[v6]:port" no longer doubles the port - unclosed <think>-style tag at the start of a response goes to reasoning, not the response - cancel now also fires during prompt processing via on_prompt_processing_progress - resize keeps at least 1 px on very thin images - remove never-run ensure_default_config_exists; add api_token to default_config.json - lmstudio requirement >=1.5.0,<2 in pyproject.toml and requirements.txt - tests for each fix; README and AGENTS.md updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a full repo audit.
user_config.jsonsaved with a BOM, as UTF-16, or holdingnull/a number no longer stops the node from loading (it falls back to defaults with a warning)timeout_secondsof 0 or less falls back to 5 instead of being reported as "Invalid JSON"server_hostof[::1]:5000no longer becomes[::1]:5000:1234<think>and never closes it (out of tokens mid-thought) is returned as reasoning, not passed downstream as the answeron_prompt_processing_progress); model load stays uncancellableensure_default_config_exists(never ran, since the file is tracked);default_config.jsongains the missingapi_tokenkeylmstudio>=1.5.0,<2: 1.5.0 is the only version exercised; 2.x needs a live run before allowing it. 1.6 prereleases (api_token) still fit.Testing
pytest -q: 185 passed;pyflakes .cleanqwen3-4b-instruct-2507: text run succeeded and unloaded; an interrupted run reportedexecution_interruptedat 3.6s and unloaded the modeluserStopped), against 2.67s to first token without it