Repository navigation
2.2.0: drop Custom from the main model dropdown - #24
Merged
Merged
Conversation
EnragedAntelope
commented
Oct 21, 2026
Owner
- Main model_selection lists real models only, so control_after_generate (increment/randomize) can no longer land on the Custom sentinel
- A non-empty custom_model_name overrides the dropdown
- VALIDATE_INPUTS(model_selection) keeps saved and API-format workflows holding the sentinel valid (checked against ComfyUI's validate_inputs; other inputs are still validated)
- Draft dropdown unchanged
- Silent one-time frontend migration for pre-2.2.0 nodes, no toast
- Tests added; README and AGENTS.md updated; version 2.2.0
- Main model_selection lists real models only; the sentinel remains only as a placeholder when discovery finds nothing - A non-empty custom_model_name overrides the dropdown - VALIDATE_INPUTS(model_selection) accepts saved workflows still holding the sentinel or an unlisted model - Draft dropdown unchanged (sentinel still means off) - Frontend refresh builds separate lists for main and draft dropdowns - Silent one-time migration: clears ignored custom text beside a real selection, moves a saved sentinel to the first model - Tests for the override and dropdown contents - README tip, AGENTS.md state and gotcha, version 2.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.